third_party/libphonenumber/libphonenumber.gyp - Issue 988633004: Linux: Enable ODR violation detection. (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libphonenumber/libphonenumber.gyp

Issue 988633004: Linux: Enable ODR violation detection. (try 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: taaaaabs! Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libphonenumber/libphonenumber.gyp

diff --git a/third_party/libphonenumber/libphonenumber.gyp b/third_party/libphonenumber/libphonenumber.gyp

index 229440bfaa861dcc0668834f12d75b27a4985cc0..f5a98fe8f9afa751f443003c0ea135da64aee486 100644

--- a/third_party/libphonenumber/libphonenumber.gyp

+++ b/third_party/libphonenumber/libphonenumber.gyp

@@ -140,6 +140,12 @@

'/wo4309',

}],

+ # libphonenumber needs to fix their ODR violations. http://crbug.com/456021

+ ['OS=="linux"', {

+ 'ldflags!': [

+ '-Wl,--detect-odr-violations',

+ ],

+ }],

}]

}

« no previous file with comments | « third_party/libphonenumber/BUILD.gn ('k') | no next file » | no next file with comments »