Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 988633002: [CLEANUP] Rename some methods of ExtensionToolbarModel to be OnFoo (Closed)

Created:
5 years, 9 months ago by zhuoyu.qian
Modified:
5 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename some methods of ExtensionToolbarModel to be OnFoo As the TODO comment by devlin in extension_toolbar_model.h, rename the methods in ExtensionToolbarModel to be OnFoo. BUG= R=rdevlin.cronin@chromium.org Committed: https://crrev.com/4a1c03d86f0fb40c3b8c1cda147de6a119ee31e1 Cr-Commit-Position: refs/heads/master@{#319822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -46 lines) Patch
M chrome/browser/extensions/extension_toolbar_model.h View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 9 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.h View 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zhuoyu.qian
Hi Devlin, PTAL, Thank you!
5 years, 9 months ago (2015-03-06 04:13:24 UTC) #1
Devlin
lgtm, thanks for the cleanup. :)
5 years, 9 months ago (2015-03-09 16:31:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988633002/1
5 years, 9 months ago (2015-03-10 01:05:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 02:26:54 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 02:27:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a1c03d86f0fb40c3b8c1cda147de6a119ee31e1
Cr-Commit-Position: refs/heads/master@{#319822}

Powered by Google App Engine
This is Rietveld 408576698