[CLEANUP] Rename some methods of ExtensionToolbarModel to be OnFoo

chrome/browser/extensions/extension_toolbar_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_
 
 #include "base/compiler_specific.h"
 #include "base/observer_list.h"
 #include "base/prefs/pref_change_registrar.h"
@@ skipping 23 matching lines @@
  public:
   ExtensionToolbarModel(Profile* profile, ExtensionPrefs* extension_prefs);
   ~ExtensionToolbarModel() override;
 
   // A class which is informed of changes to the model; represents the view of
   // MVC. Also used for signaling view changes such as showing extension popups.
   // TODO(devlin): Should this really be an observer? It acts more like a
   // delegate.
   class Observer {
    public:
-    // TODO(devlin): Rename these methods to be OnFoo.
     // Signals that an |extension| has been added to the toolbar at |index|.
     // This will *only* be called after the toolbar model has been initialized.
-    virtual void ToolbarExtensionAdded(const Extension* extension,
-                                       int index) = 0;
+    virtual void OnToolbarExtensionAdded(const Extension* extension,
+                                         int index) = 0;
 
     // Signals that the given |extension| has been removed from the toolbar.
-    virtual void ToolbarExtensionRemoved(const Extension* extension) = 0;
+    virtual void OnToolbarExtensionRemoved(const Extension* extension) = 0;
 
     // Signals that the given |extension| has been moved to |index|. |index| is
     // the desired *final* index of the extension (that is, in the adjusted
     // order, extension should be at |index|).
-    virtual void ToolbarExtensionMoved(const Extension* extension,
-                                       int index) = 0;
+    virtual void OnToolbarExtensionMoved(const Extension* extension,
+                                         int index) = 0;
 
     // Signals that the browser action for the given |extension| has been
     // updated.
-    virtual void ToolbarExtensionUpdated(const Extension* extension) = 0;
+    virtual void OnToolbarExtensionUpdated(const Extension* extension) = 0;
 
     // Signals the |extension| to show the popup now in the active window.
     // If |grant_active_tab| is true, then active tab permissions should be
     // given to the extension (only do this if this is through a user action).
     // Returns true if a popup was slated to be shown.
     virtual bool ShowExtensionActionPopup(const Extension* extension,
                                           bool grant_active_tab) = 0;
 
     // Signals when the container needs to be redrawn because of a size change,
     // and when the model has finished loading.
-    virtual void ToolbarVisibleCountChanged() = 0;
+    virtual void OnToolbarVisibleCountChanged() = 0;
 
     // Signals that the model has entered or exited highlighting mode, or that
     // the extensions being highlighted have (probably*) changed. Highlighting
     // mode indicates that only a subset of the extensions are actively
     // displayed, and those extensions should be highlighted for extra emphasis.
     // * probably, because if we are in highlight mode and receive a call to
     //   highlight a new set of extensions, we do not compare the current set
     //   with the new set (and just assume the new set is different).
-    virtual void ToolbarHighlightModeChanged(bool is_highlighting) = 0;
+    virtual void OnToolbarHighlightModeChanged(bool is_highlighting) = 0;
 
     // Signals that the toolbar model has been initialized, so that if any
     // observers were postponing animation during the initialization stage, they
     // can catch up.
     virtual void OnToolbarModelInitialized() = 0;
 
     // Returns the browser associated with the Observer.
     virtual Browser* GetBrowser() = 0;
 
    protected:
@@ skipping 174 matching lines @@
   base::Closure pref_change_callback_;
 
   base::WeakPtrFactory<ExtensionToolbarModel> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionToolbarModel);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_TOOLBAR_MODEL_H_