Index: chrome/browser/extensions/extension_toolbar_model.h |
diff --git a/chrome/browser/extensions/extension_toolbar_model.h b/chrome/browser/extensions/extension_toolbar_model.h |
index 748264827c96390ee75d22b2b772f123df3c7396..f0de29ce5414c1e8e8074e5b65e02cee7e1a2699 100644 |
--- a/chrome/browser/extensions/extension_toolbar_model.h |
+++ b/chrome/browser/extensions/extension_toolbar_model.h |
@@ -41,24 +41,23 @@ class ExtensionToolbarModel : public content::NotificationObserver, |
// delegate. |
class Observer { |
public: |
- // TODO(devlin): Rename these methods to be OnFoo. |
// Signals that an |extension| has been added to the toolbar at |index|. |
// This will *only* be called after the toolbar model has been initialized. |
- virtual void ToolbarExtensionAdded(const Extension* extension, |
- int index) = 0; |
+ virtual void OnToolbarExtensionAdded(const Extension* extension, |
+ int index) = 0; |
// Signals that the given |extension| has been removed from the toolbar. |
- virtual void ToolbarExtensionRemoved(const Extension* extension) = 0; |
+ virtual void OnToolbarExtensionRemoved(const Extension* extension) = 0; |
// Signals that the given |extension| has been moved to |index|. |index| is |
// the desired *final* index of the extension (that is, in the adjusted |
// order, extension should be at |index|). |
- virtual void ToolbarExtensionMoved(const Extension* extension, |
- int index) = 0; |
+ virtual void OnToolbarExtensionMoved(const Extension* extension, |
+ int index) = 0; |
// Signals that the browser action for the given |extension| has been |
// updated. |
- virtual void ToolbarExtensionUpdated(const Extension* extension) = 0; |
+ virtual void OnToolbarExtensionUpdated(const Extension* extension) = 0; |
// Signals the |extension| to show the popup now in the active window. |
// If |grant_active_tab| is true, then active tab permissions should be |
@@ -69,7 +68,7 @@ class ExtensionToolbarModel : public content::NotificationObserver, |
// Signals when the container needs to be redrawn because of a size change, |
// and when the model has finished loading. |
- virtual void ToolbarVisibleCountChanged() = 0; |
+ virtual void OnToolbarVisibleCountChanged() = 0; |
// Signals that the model has entered or exited highlighting mode, or that |
// the extensions being highlighted have (probably*) changed. Highlighting |
@@ -78,7 +77,7 @@ class ExtensionToolbarModel : public content::NotificationObserver, |
// * probably, because if we are in highlight mode and receive a call to |
// highlight a new set of extensions, we do not compare the current set |
// with the new set (and just assume the new set is different). |
- virtual void ToolbarHighlightModeChanged(bool is_highlighting) = 0; |
+ virtual void OnToolbarHighlightModeChanged(bool is_highlighting) = 0; |
// Signals that the toolbar model has been initialized, so that if any |
// observers were postponing animation during the initialization stage, they |