Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 98853009: Fixing Java style issues in android_webview. (Closed)

Created:
7 years ago by aurimas (slooooooooow)
Modified:
7 years ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Fixing Java style issues in android_webview. BUG=320711 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239661

Patch Set 1 #

Total comments: 4

Patch Set 2 : Bo's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -354 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AndroidProtocolHandler.java View 5 chunks +16 lines, -16 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwAutofillManagerDelegate.java View 2 chunks +6 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 9 chunks +22 lines, -24 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClient.java View 2 chunks +1 line, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java View 4 chunks +12 lines, -12 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwCookieManager.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwGeolocationPermissions.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwLayoutSizer.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwPicture.java View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwPrintDocumentAdapter.java View 2 chunks +10 lines, -12 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwQuotaManagerBridge.java View 2 chunks +5 lines, -5 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwResource.java View 2 chunks +3 lines, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 5 chunks +20 lines, -20 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java View 2 chunks +3 lines, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwZoomControls.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/DefaultVideoPosterRequestHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/HttpAuthDatabase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/InterceptedRequestData.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/JavaBrowserViewRendererHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/JsPromptResultReceiver.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/JsResultHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/JsResultReceiver.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/SslUtil.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 3 chunks +19 lines, -19 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientAutoLoginTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java View 4 chunks +14 lines, -13 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java View 1 chunk +8 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnFormResubmissionTest.java View 1 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnScaleChangedTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java View 5 chunks +8 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 4 chunks +6 lines, -6 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwLayoutSizerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwQuotaManagerBridgeTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 10 chunks +12 lines, -13 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java View 6 chunks +13 lines, -13 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwZoomTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClearHistoryTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientAddMessageToConsoleTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ContentViewMiscTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/FullScreenVideoTestAwContentsClient.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpAuthDatabaseTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadUrlTest.java View 3 chunks +9 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/SaveRestoreStateTest.java View 3 chunks +8 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java View 4 chunks +37 lines, -37 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewAsynchronousFindApisTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewFindApisTestBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/CommonResources.java View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/ImagePageGenerator.java View 3 chunks +10 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 3 chunks +5 lines, -5 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java View 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellResourceProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestRunnerActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/NullContentsClient.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/test/TestContentProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/unittestjava/src/org/chromium/android_webview/unittest/InputStreamUnittest.java View 2 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aurimas (slooooooooow)
Hey Bo, Please take a look at this CL. Aurimas
7 years ago (2013-12-10 01:36:52 UTC) #1
boliu
lgtm! https://codereview.chromium.org/98853009/diff/1/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java File android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java (right): https://codereview.chromium.org/98853009/diff/1/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java#newcode30 android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:30: * The unit of all the values in ...
7 years ago (2013-12-10 01:52:15 UTC) #2
aurimas (slooooooooow)
https://codereview.chromium.org/98853009/diff/1/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java File android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java (right): https://codereview.chromium.org/98853009/diff/1/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java#newcode30 android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java:30: * The unit of all the values in this ...
7 years ago (2013-12-10 02:00:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/98853009/20001
7 years ago (2013-12-10 03:42:55 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-10 05:06:12 UTC) #5
Message was sent while issue was closed. 
Change committed as 239661

Powered by Google App Engine
This is Rietveld 408576698