android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java - Issue 98853009: Fixing Java style issues in android_webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

Issue 98853009: Fixing Java style issues in android_webview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bo's nits Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/WebViewFindApisTestBase.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/util/CommonResources.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

index fd52c575758762e9f186a260b479156964f2eb09..0a1f503b436ad1bbcc823552604c9aca46a0cbfe 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

@@ -1,4 +1,4 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

@@ -20,10 +20,10 @@ import org.chromium.content.browser.test.util.CallbackHelper;

import java.util.concurrent.atomic.AtomicBoolean;

public class WebViewModalDialogOverrideTest extends AwTestBase {

- private final static String EMPTY_PAGE =

+ private static final String EMPTY_PAGE =

"<!doctype html>" +

"<title>Modal Dialog Test</title><p>Testcase.</p>";

- private final static String BEFORE_UNLOAD_URL =

+ private static final String BEFORE_UNLOAD_URL =

"<!doctype html>" +

"<head><script>window.onbeforeunload=function() {" +

"return 'Are you sure?';" +