Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java

Issue 98853009: Fixing Java style issues in android_webview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Bo's nits Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
index 5d0e5ce40c3a7272a10ff1053c62d2e13453b544..59178454a6ebc9e992e5dd51ca20569a8621d7aa 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -35,10 +35,10 @@ import java.util.concurrent.TimeUnit;
* Tests for the WebViewClient.shouldOverrideUrlLoading() method.
*/
public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
- private final static String ABOUT_BLANK_URL = "about:blank";
- private final static String DATA_URL = "data:text/html,<div/>";
- private final static String REDIRECT_TARGET_PATH = "/redirect_target.html";
- private final static String TITLE = "TITLE";
+ private static final String ABOUT_BLANK_URL = "about:blank";
+ private static final String DATA_URL = "data:text/html,<div/>";
+ private static final String REDIRECT_TARGET_PATH = "/redirect_target.html";
+ private static final String TITLE = "TITLE";
private static final long TEST_TIMEOUT = 20000L;
private static final long CHECK_INTERVAL = 100;
@@ -164,7 +164,7 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
"} " +
"function doRedirectReplace() {" +
"location.replace('" + url + "');" +
- "} "+
+ "} " +
"</script>",
String.format("<iframe onLoad=\"setTimeout('doRedirect%s()', %d);\" />",
method, timeout));
@@ -173,7 +173,7 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
private String getHtmlForPageWithSimplePostFormTo(String destination) {
return makeHtmlPageFrom("",
"<form action=\"" + destination + "\" method=\"post\">" +
- "<input type=\"submit\" value=\"post\" id=\"link\">"+
+ "<input type=\"submit\" value=\"post\" id=\"link\">" +
"</form>");
}
@@ -226,7 +226,7 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
contentsClient.getShouldOverrideUrlLoadingHelper();
final String[] pageTitles = new String[] { "page1", "page2", "page3" };
- for (String title: pageTitles) {
+ for (String title : pageTitles) {
loadDataSync(awContents, contentsClient.getOnPageFinishedHelper(),
CommonResources.makeHtmlPageFrom("<title>" + title + "</title>", ""),
"text/html", false);

Powered by Google App Engine
This is Rietveld 408576698