DescriptionRevert of Always create top controls manager (patchset #6 id:100001 of https://codereview.chromium.org/961023002/)
Reason for revert:
This seems to be causing the virtual/threaded/printing/return-from-printing-mode.html layout test to fail:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CustomLauncherPageBrowserTest.LauncherPageFocusTraversal&testType=browser_tests
Original issue's description:
> Always create top controls manager.
>
> This CL removes the calculate_top_controls_position flag and instead
> always creates the top controls manager. The methods of the manager
> become no-ops if the top controls height is 0 so that it becomes
> effectively enabled when a top controls height gets set.
>
> This fixes the attached bug because some Android Chrome UI pages don't
> have top controls but the manager was still created. These pages set
> the height to 0 to hide the top controls but the methods of the
> manager were still getting called. This caused a crash in Blink since
> ScrollBy would try to calculate the shown ratio with a 0 height, causing
> a NaN to propagate into Blink.
>
> BUG=460007
>
> Committed: https://crrev.com/7610e74eacde3468853c9765bd3f726c14df04c1
> Cr-Commit-Position: refs/heads/master@{#319257}
TBR=aelias@chromium.org,yfriedman@chromium.org,avi@chromium.org,dpolukhin@chromium.org,bokan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460007
Committed: https://crrev.com/60e299a0dd4aaa535b1c60cbc42e3f92c4c620d4
Cr-Commit-Position: refs/heads/master@{#319371}
Patch Set 1 #
Created: 5 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|