Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 986433004: Revert of Always create top controls manager (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Always create top controls manager (patchset #6 id:100001 of https://codereview.chromium.org/961023002/) Reason for revert: This seems to be causing the virtual/threaded/printing/return-from-printing-mode.html layout test to fail: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CustomLauncherPageBrowserTest.LauncherPageFocusTraversal&testType=browser_tests Original issue's description: > Always create top controls manager. > > This CL removes the calculate_top_controls_position flag and instead > always creates the top controls manager. The methods of the manager > become no-ops if the top controls height is 0 so that it becomes > effectively enabled when a top controls height gets set. > > This fixes the attached bug because some Android Chrome UI pages don't > have top controls but the manager was still created. These pages set > the height to 0 to hide the top controls but the methods of the > manager were still getting called. This caused a crash in Blink since > ScrollBy would try to calculate the shown ratio with a 0 height, causing > a NaN to propagate into Blink. > > BUG=460007 > > Committed: https://crrev.com/7610e74eacde3468853c9765bd3f726c14df04c1 > Cr-Commit-Position: refs/heads/master@{#319257} TBR=aelias@chromium.org,yfriedman@chromium.org,avi@chromium.org,dpolukhin@chromium.org,bokan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460007 Committed: https://crrev.com/60e299a0dd4aaa535b1c60cbc42e3f92c4c620d4 Cr-Commit-Position: refs/heads/master@{#319371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -74 lines) Patch
M cc/base/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/input/top_controls_manager.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M cc/input/top_controls_manager_unittest.cc View 2 chunks +1 line, -47 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 10 chunks +27 lines, -15 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 3 chunks +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ApplicationInitialization.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
Created Revert of Always create top controls manager
5 years, 9 months ago (2015-03-05 23:59:25 UTC) #1
Dirk Pranke
Reason for revert: This seems to be causing the virtual/threaded/printing/return-from-printing-mode.html layout test to fail: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CustomLauncherPageBrowserTest.LauncherPageFocusTraversal&testType=browser_tests
5 years, 9 months ago (2015-03-06 00:00:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986433004/1
5 years, 9 months ago (2015-03-06 00:00:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 00:01:11 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 00:01:41 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60e299a0dd4aaa535b1c60cbc42e3f92c4c620d4
Cr-Commit-Position: refs/heads/master@{#319371}

Powered by Google App Engine
This is Rietveld 408576698