Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3646)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 986433004: Revert of Always create top controls manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 2f4d9a9b057cdbb9c21264f24606b5cc6b671726..c03f7f79528ed0ed244c2fd301763b2bdfe97f20 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -241,10 +241,12 @@
TRACE_EVENT_OBJECT_CREATED_WITH_ID(
TRACE_DISABLED_BY_DEFAULT("cc.debug"), "cc::LayerTreeHostImpl", id_);
- top_controls_manager_ =
- TopControlsManager::Create(this,
- settings.top_controls_show_threshold,
- settings.top_controls_hide_threshold);
+ if (settings.calculate_top_controls_position) {
+ top_controls_manager_ =
+ TopControlsManager::Create(this,
+ settings.top_controls_show_threshold,
+ settings.top_controls_hide_threshold);
+ }
}
LayerTreeHostImpl::~LayerTreeHostImpl() {
@@ -914,7 +916,8 @@
}
void LayerTreeHostImpl::MainThreadHasStoppedFlinging() {
- top_controls_manager_->MainThreadHasStoppedFlinging();
+ if (top_controls_manager_)
+ top_controls_manager_->MainThreadHasStoppedFlinging();
if (input_handler_client_)
input_handler_client_->MainThreadHasStoppedFlinging();
}
@@ -1420,10 +1423,12 @@
metadata.root_layer_size = active_tree_->ScrollableSize();
metadata.min_page_scale_factor = active_tree_->min_page_scale_factor();
metadata.max_page_scale_factor = active_tree_->max_page_scale_factor();
- metadata.location_bar_offset =
- gfx::Vector2dF(0.f, top_controls_manager_->ControlsTopOffset());
- metadata.location_bar_content_translation =
- gfx::Vector2dF(0.f, top_controls_manager_->ContentTopOffset());
+ if (top_controls_manager_) {
+ metadata.location_bar_offset =
+ gfx::Vector2dF(0.f, top_controls_manager_->ControlsTopOffset());
+ metadata.location_bar_content_translation =
+ gfx::Vector2dF(0.f, top_controls_manager_->ContentTopOffset());
+ }
active_tree_->GetViewportSelection(&metadata.selection_start,
&metadata.selection_end);
@@ -1653,7 +1658,7 @@
LayerImpl* inner_container = active_tree_->InnerViewportContainerLayer();
LayerImpl* outer_container = active_tree_->OuterViewportContainerLayer();
- if (!inner_container)
+ if (!inner_container || !top_controls_manager_)
return;
ViewportAnchor anchor(InnerViewportScrollLayer(),
@@ -2351,7 +2356,8 @@
InputHandler::ScrollInputType type) {
TRACE_EVENT0("cc", "LayerTreeHostImpl::ScrollBegin");
- top_controls_manager_->ScrollBegin();
+ if (top_controls_manager_)
+ top_controls_manager_->ScrollBegin();
DCHECK(!CurrentlyScrollingLayer());
ClearCurrentlyScrollingLayer();
@@ -2561,6 +2567,9 @@
bool LayerTreeHostImpl::ShouldTopControlsConsumeScroll(
const gfx::Vector2dF& scroll_delta) const {
DCHECK(CurrentlyScrollingLayer());
+
+ if (!top_controls_manager_)
+ return false;
// Always consume if it's in the direction to show the top controls.
if (scroll_delta.y() < 0)
@@ -2802,7 +2811,8 @@
}
void LayerTreeHostImpl::ScrollEnd() {
- top_controls_manager_->ScrollEnd();
+ if (top_controls_manager_)
+ top_controls_manager_->ScrollEnd();
ClearCurrentlyScrollingLayer();
}
@@ -2923,7 +2933,8 @@
active_tree_->SetCurrentlyScrollingLayer(
active_tree_->InnerViewportScrollLayer());
}
- top_controls_manager_->PinchBegin();
+ if (top_controls_manager_)
+ top_controls_manager_->PinchBegin();
}
void LayerTreeHostImpl::PinchGestureUpdate(float magnify_delta,
@@ -2982,7 +2993,8 @@
pinch_gesture_end_should_clear_scrolling_layer_ = false;
ClearCurrentlyScrollingLayer();
}
- top_controls_manager_->PinchEnd();
+ if (top_controls_manager_)
+ top_controls_manager_->PinchEnd();
client_->SetNeedsCommitOnImplThread();
// When a pinch ends, we may be displaying content cached at incorrect scales,
// so updating draw properties and drawing will ensure we are using the right
@@ -3077,7 +3089,7 @@
}
void LayerTreeHostImpl::AnimateTopControls(base::TimeTicks time) {
- if (!top_controls_manager_->animation())
+ if (!top_controls_manager_ || !top_controls_manager_->animation())
return;
gfx::Vector2dF scroll = top_controls_manager_->Animate(time);
« no previous file with comments | « cc/trees/layer_tree_host.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698