Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 9864022: Move DataSource::SetPreload() to BufferedDataSource. (Closed)

Created:
8 years, 9 months ago by scherkus (not reviewing)
Modified:
8 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move DataSource::SetPreload() to BufferedDataSource. Preload is a concept that only applies to HTML media elements and is only implemented by BufferedDataSource. Since the preload value is known when BufferedDataSource is created by WebMediaPlayerImpl, we can remove a lot of unnecessary plumbing in the media code. TEST=amount of data buffered (either visible on controls or via buffered attribute) is the same for each preload value (none, metadata, and auto). http://mastodon.sea/demos/preload contains a test page. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130004

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -128 lines) Patch
M media/base/data_source.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/demuxer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/base/pipeline.h View 4 chunks +0 lines, -15 lines 0 comments Download
M media/base/pipeline.cc View 4 chunks +0 lines, -25 lines 0 comments Download
M media/base/pipeline_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D media/base/preload.h View 1 chunk +0 lines, -25 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/dummy_demuxer.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/dummy_demuxer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/filters/file_data_source.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/file_data_source.cc View 1 chunk +1 line, -5 lines 0 comments Download
M media/media.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/player_x11/data_source_logger.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/player_x11/data_source_logger.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/media/buffered_data_source.h View 5 chunks +5 lines, -5 lines 0 comments Download
M webkit/media/buffered_data_source.cc View 5 chunks +7 lines, -12 lines 0 comments Download
M webkit/media/buffered_data_source_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/media/preload.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/media/webkit_media.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 2 chunks +6 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
scherkus (not reviewing)
https://chromiumcodereview.appspot.com/9864022/diff/1/webkit/media/webmediaplayer_impl.cc File webkit/media/webmediaplayer_impl.cc (right): https://chromiumcodereview.appspot.com/9864022/diff/1/webkit/media/webmediaplayer_impl.cc#newcode377 webkit/media/webmediaplayer_impl.cc:377: // XXX: Why do I need to use webkit_media:: ...
8 years, 9 months ago (2012-03-27 02:52:06 UTC) #1
scherkus (not reviewing)
note this CL depends on https://chromiumcodereview.appspot.com/9836102/
8 years, 9 months ago (2012-03-27 02:52:23 UTC) #2
scherkus (not reviewing)
ping vrk!
8 years, 8 months ago (2012-03-30 20:12:09 UTC) #3
vrk (LEFT CHROMIUM)
8 years, 8 months ago (2012-03-30 23:34:49 UTC) #4
LGTM

So much nicer!! Thanks scherkus!

Powered by Google App Engine
This is Rietveld 408576698