Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: webkit/media/buffered_data_source.cc

Issue 9864022: Move DataSource::SetPreload() to BufferedDataSource. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/buffered_data_source.cc
diff --git a/webkit/media/buffered_data_source.cc b/webkit/media/buffered_data_source.cc
index 151fe861562c37f41bba164572d14e19568c0931..2911ef528089dfb8466bd6bdfba68fc6753ebdc0 100644
--- a/webkit/media/buffered_data_source.cc
+++ b/webkit/media/buffered_data_source.cc
@@ -42,7 +42,7 @@ BufferedDataSource::BufferedDataSource(
stopped_on_render_loop_(false),
media_is_paused_(true),
media_has_played_(false),
- preload_(media::AUTO),
+ preload_(AUTO),
cache_miss_retries_left_(kNumCacheMissRetries),
bitrate_(0),
playback_rate_(0.0),
@@ -108,6 +108,11 @@ void BufferedDataSource::Initialize(
frame_);
}
+void BufferedDataSource::SetPreload(Preload preload) {
+ DCHECK(MessageLoop::current() == render_loop_);
+ preload_ = preload;
+}
+
bool BufferedDataSource::HasSingleOrigin() {
DCHECK(MessageLoop::current() == render_loop_);
return loader_.get() ? loader_->HasSingleOrigin() : true;
@@ -139,11 +144,6 @@ void BufferedDataSource::SetPlaybackRate(float playback_rate) {
&BufferedDataSource::SetPlaybackRateTask, this, playback_rate));
}
-void BufferedDataSource::SetPreload(media::Preload preload) {
- render_loop_->PostTask(FROM_HERE, base::Bind(
- &BufferedDataSource::SetPreloadTask, this, preload));
-}
-
void BufferedDataSource::SetBitrate(int bitrate) {
render_loop_->PostTask(FROM_HERE, base::Bind(
&BufferedDataSource::SetBitrateTask, this, bitrate));
@@ -276,11 +276,6 @@ void BufferedDataSource::SetPlaybackRateTask(float playback_rate) {
loader_->UpdateDeferStrategy(strategy);
}
-void BufferedDataSource::SetPreloadTask(media::Preload preload) {
- DCHECK(MessageLoop::current() == render_loop_);
- preload_ = preload;
-}
-
void BufferedDataSource::SetBitrateTask(int bitrate) {
DCHECK(MessageLoop::current() == render_loop_);
DCHECK(loader_.get());
@@ -294,7 +289,7 @@ BufferedDataSource::ChooseDeferStrategy() {
DCHECK(MessageLoop::current() == render_loop_);
// If the page indicated preload=metadata, then load exactly what is needed
// needed for starting playback.
- if (!media_has_played_ && preload_ == media::METADATA)
+ if (!media_has_played_ && preload_ == METADATA)
return BufferedResourceLoader::kReadThenDefer;
// If the playback has started (at which point the preload value is ignored)

Powered by Google App Engine
This is Rietveld 408576698