Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: webkit/media/buffered_data_source.h

Issue 9864022: Move DataSource::SetPreload() to BufferedDataSource. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/buffered_data_source.h
diff --git a/webkit/media/buffered_data_source.h b/webkit/media/buffered_data_source.h
index ea13e6ee51a2e1efa46134f661c386cb43106c48..8dcc008afd9a5d875860a07d4b42aa04d0b92abf 100644
--- a/webkit/media/buffered_data_source.h
+++ b/webkit/media/buffered_data_source.h
@@ -14,6 +14,7 @@
#include "media/base/data_source.h"
#include "media/base/pipeline_status.h"
#include "webkit/media/buffered_resource_loader.h"
+#include "webkit/media/preload.h"
class MessageLoop;
@@ -40,6 +41,9 @@ class BufferedDataSource : public media::DataSource {
void Initialize(const GURL& url,
const media::PipelineStatusCB& status_cb);
+ // Adjusts the buffering algorithm based on the given preload value.
+ void SetPreload(Preload preload);
+
// Returns true if the media resource has a single origin, false otherwise.
//
// Method called on the render thread.
@@ -65,7 +69,6 @@ class BufferedDataSource : public media::DataSource {
const media::DataSource::ReadCB& read_cb) OVERRIDE;
virtual bool GetSize(int64* size_out) OVERRIDE;
virtual bool IsStreaming() OVERRIDE;
- virtual void SetPreload(media::Preload preload) OVERRIDE;
virtual void SetBitrate(int bitrate) OVERRIDE;
protected:
@@ -94,9 +97,6 @@ class BufferedDataSource : public media::DataSource {
// and signals the buffered resource loader accordingly.
void SetPlaybackRateTask(float playback_rate);
- // This task saves the preload value for the media.
- void SetPreloadTask(media::Preload preload);
-
// Tells |loader_| the bitrate of the media.
void SetBitrateTask(int bitrate);
@@ -210,7 +210,7 @@ class BufferedDataSource : public media::DataSource {
// This variable holds the value of the preload attribute for the video
// element.
- media::Preload preload_;
+ Preload preload_;
// Number of cache miss retries left.
int cache_miss_retries_left_;

Powered by Google App Engine
This is Rietveld 408576698