Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 986333002: Fix ExtensionInstallPromptUnittest.DelegatedPromptShowsOptionalPermissions on Win official (Closed)

Created:
5 years, 9 months ago by Marc Treib
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ExtensionInstallPromptUnittest.DelegatedPromptShowsOptionalPermissions on Win official BUG=464040 Committed: https://crrev.com/f00002a0cfc699faa4228b697ac77ee433df06d0 Cr-Commit-Position: refs/heads/master@{#319659}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/extensions/extension_install_prompt_unittest.cc View 2 chunks +4 lines, -5 lines 3 comments Download

Messages

Total messages: 12 (2 generated)
Marc Treib
PTAL! https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/extension_install_prompt_unittest.cc File chrome/browser/extensions/extension_install_prompt_unittest.cc (left): https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/extension_install_prompt_unittest.cc#oldcode112 chrome/browser/extensions/extension_install_prompt_unittest.cc:112: ListBuilder().Append("location"))) For some reason, "location" does not result ...
5 years, 9 months ago (2015-03-09 14:05:59 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/extension_install_prompt_unittest.cc File chrome/browser/extensions/extension_install_prompt_unittest.cc (left): https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/extension_install_prompt_unittest.cc#oldcode112 chrome/browser/extensions/extension_install_prompt_unittest.cc:112: ListBuilder().Append("location"))) On 2015/03/09 14:05:59, Marc Treib wrote: > ...
5 years, 9 months ago (2015-03-09 16:33:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986333002/1
5 years, 9 months ago (2015-03-09 16:48:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 17:11:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f00002a0cfc699faa4228b697ac77ee433df06d0 Cr-Commit-Position: refs/heads/master@{#319659}
5 years, 9 months ago (2015-03-09 17:12:19 UTC) #7
Marc Treib
https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/extension_install_prompt_unittest.cc File chrome/browser/extensions/extension_install_prompt_unittest.cc (left): https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/extension_install_prompt_unittest.cc#oldcode112 chrome/browser/extensions/extension_install_prompt_unittest.cc:112: ListBuilder().Append("location"))) On 2015/03/09 16:33:53, kalman wrote: > On 2015/03/09 ...
5 years, 9 months ago (2015-03-09 17:30:40 UTC) #8
not at google - send to devlin
On 2015/03/09 17:30:40, Marc Treib wrote: > https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/extension_install_prompt_unittest.cc > File chrome/browser/extensions/extension_install_prompt_unittest.cc (left): > > https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/extension_install_prompt_unittest.cc#oldcode112 ...
5 years, 9 months ago (2015-03-09 17:32:55 UTC) #9
Marc Treib
On 2015/03/09 17:32:55, kalman wrote: > On 2015/03/09 17:30:40, Marc Treib wrote: > > > ...
5 years, 9 months ago (2015-03-09 17:36:45 UTC) #10
Marc Treib
On 2015/03/09 17:36:45, Marc Treib wrote: > On 2015/03/09 17:32:55, kalman wrote: > > On ...
5 years, 9 months ago (2015-03-11 14:02:42 UTC) #11
not at google - send to devlin
5 years, 9 months ago (2015-03-11 17:56:54 UTC) #12
Message was sent while issue was closed. 
On 2015/03/11 14:02:42, Marc Treib wrote:
> On 2015/03/09 17:36:45, Marc Treib wrote:
> > On 2015/03/09 17:32:55, kalman wrote:
> > > On 2015/03/09 17:30:40, Marc Treib wrote:
> > > >
> > >
> >
>
https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/ex...
> > > > File chrome/browser/extensions/extension_install_prompt_unittest.cc
> (left):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/986333002/diff/1/chrome/browser/extensions/ex...
> > > > chrome/browser/extensions/extension_install_prompt_unittest.cc:112:
> > > > ListBuilder().Append("location")))
> > > > On 2015/03/09 16:33:53, kalman wrote:
> > > > > On 2015/03/09 14:05:59, Marc Treib wrote:
> > > > > > For some reason, "location" does not result in any warning message
on
> > Win
> > > > > > official (both in optional and required permissions). Out of
> curiosity:
> > Do
> > > > you
> > > > > > know why?
> > > > > 
> > > > > Well that's weird. Location is supposed to be a valid permission.
> > > > 
> > > > Yup, especially as it works fine on all the other platforms - it's only
in
> > Win
> > > > Official builds that it doesn't. I guess I should investigate...
> > > 
> > > what channel do the win official builds run?
> > 
> > I don't know. I can reproduce this locally though (with just
"branding=Chrome
> > buildtype=Official"). I just haven't bothered to track it down yet, since
> > official builds on Windows take ages.
> 
> Following up, in case you're curious: Your hunch about the channel was
correct.
> location requires Dev or newer
>
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...),
> and official builds run as stable.

Alright cool. For future reference you can override the channel for testing
(ScopedCurrentChannel) though that shouldn't be necessary here.

Powered by Google App Engine
This is Rietveld 408576698