Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: chrome/browser/extensions/extension_install_prompt_unittest.cc

Issue 986333002: Fix ExtensionInstallPromptUnittest.DelegatedPromptShowsOptionalPermissions on Win official (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_prompt_unittest.cc
diff --git a/chrome/browser/extensions/extension_install_prompt_unittest.cc b/chrome/browser/extensions/extension_install_prompt_unittest.cc
index e1a671caf1f0c42452f6cd6888f08456e61a17ea..a318b4926e2cea34a841fb19b2c61f7b4b0bc526 100644
--- a/chrome/browser/extensions/extension_install_prompt_unittest.cc
+++ b/chrome/browser/extensions/extension_install_prompt_unittest.cc
@@ -82,8 +82,7 @@ TEST(ExtensionInstallPromptUnittest, PromptShowsWithheldPermissions) {
.Set("permissions",
ListBuilder().Append("http://*/*")
.Append("http://www.google.com/")
- .Append("tabs")))
- .Build();
+ .Append("tabs"))).Build();
ExtensionInstallPrompt prompt(nullptr /* no web contents in this test */);
base::RunLoop run_loop;
@@ -107,10 +106,10 @@ TEST(ExtensionInstallPromptUnittest, DelegatedPromptShowsOptionalPermissions) {
.Set("version", "1.0")
.Set("manifest_version", 2)
.Set("description", "Random Ext")
- .Set("permissions", ListBuilder().Append("tabs"))
+ .Set("permissions",
+ ListBuilder().Append("clipboardRead"))
.Set("optional_permissions",
- ListBuilder().Append("location")))
Marc Treib 2015/03/09 14:05:59 For some reason, "location" does not result in any
not at google - send to devlin 2015/03/09 16:33:53 Well that's weird. Location is supposed to be a va
Marc Treib 2015/03/09 17:30:40 Yup, especially as it works fine on all the other
- .Build();
+ ListBuilder().Append("tabs"))).Build();
ExtensionInstallPrompt prompt(nullptr /* no web contents in this test */);
base::RunLoop run_loop;
prompt.set_callback_for_test(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698