Fix ExtensionInstallPromptUnittest.DelegatedPromptShowsOptionalPermissions on Win official

chrome/browser/extensions/extension_install_prompt_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_install_prompt_show_params.h"
 #include "content/public/test/test_browser_thread_bundle.h"
@@ skipping 64 matching lines @@
 
   scoped_refptr<const Extension> extension =
       ExtensionBuilder().SetManifest(
           DictionaryBuilder().Set("name", "foo")
                              .Set("version", "1.0")
                              .Set("manifest_version", 2)
                              .Set("description", "Random Ext")
                              .Set("permissions",
                                   ListBuilder().Append("http://*/*")
                                                .Append("http://www.google.com/")
-                                               .Append("tabs")))
-                             .Build();
+                                               .Append("tabs"))).Build();
   ExtensionInstallPrompt prompt(nullptr /* no web contents in this test */);
   base::RunLoop run_loop;
 
   // We expect <all_hosts> to be withheld, but http://www.google.com/ and tabs
   // permissions should be granted as regular permissions.
   prompt.ConfirmInstall(
       nullptr,
       extension.get(),
       base::Bind(&VerifyPromptPermissionsCallback,
                  run_loop.QuitClosure(),
                  2u,  // |regular_permissions_count|.
                  1u));  // |withheld_permissions_count|.
   run_loop.Run();
 }
 
 TEST(ExtensionInstallPromptUnittest, DelegatedPromptShowsOptionalPermissions) {
   content::TestBrowserThreadBundle thread_bundle;
   scoped_refptr<const Extension> extension =
       ExtensionBuilder().SetManifest(
           DictionaryBuilder().Set("name", "foo")
                              .Set("version", "1.0")
                              .Set("manifest_version", 2)
                              .Set("description", "Random Ext")
-                             .Set("permissions", ListBuilder().Append("tabs"))
+                             .Set("permissions",
+                                  ListBuilder().Append("clipboardRead"))
                              .Set("optional_permissions",
-                                  ListBuilder().Append("location")))

[Marc Treib, 2015/03/09 14:05:59]

For some reason, "location" does not result in any warning message on Win
official (both in optional and required permissions). Out of curiosity: Do you
know why?

[not at google - send to devlin, 2015/03/09 16:33:53]

Well that's weird. Location is supposed to be a valid permission.

[Marc Treib, 2015/03/09 17:30:40]

Yup, especially as it works fine on all the other platforms - it's only in Win
Official builds that it doesn't. I guess I should investigate...

-                             .Build();
+                                  ListBuilder().Append("tabs"))).Build();
   ExtensionInstallPrompt prompt(nullptr /* no web contents in this test */);
   base::RunLoop run_loop;
   prompt.set_callback_for_test(
       base::Bind(&VerifyPromptPermissionsCallback,
                  run_loop.QuitClosure(),
                  2u,  // |regular_permissions_count|.
                  0u));  // |withheld_permissions_count|.
   prompt.ConfirmPermissionsForDelegatedInstall(nullptr,  // no delegate
                                                extension.get(),
                                                "Username",
                                                nullptr);  // no icon
   run_loop.Run();
 }
 
 }  // namespace extensions