Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/gn/ninja_toolchain_writer.cc

Issue 986113002: tools/gn: Convert for loops to use the new range-based loops in C++11. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_toolchain_writer.cc
diff --git a/tools/gn/ninja_toolchain_writer.cc b/tools/gn/ninja_toolchain_writer.cc
index 012247103001075e7b321a2402f05977fea03c5e..0cb25e8a10f6c64d57ea286345775518e60c07fb 100644
--- a/tools/gn/ninja_toolchain_writer.cc
+++ b/tools/gn/ninja_toolchain_writer.cc
@@ -128,9 +128,9 @@ void NinjaToolchainWriter::WriteRulePattern(const char* name,
void NinjaToolchainWriter::WriteSubninjas() {
// Write subninja commands for each generated target.
- for (size_t i = 0; i < targets_.size(); i++) {
- OutputFile ninja_file(targets_[i]->settings()->build_settings(),
- GetNinjaFileForTarget(targets_[i]));
+ for (const auto& target: targets_) {
scottmg 2015/03/23 17:24:20 nit; space before :
tfarina 2015/03/25 14:14:31 Done.
+ OutputFile ninja_file(target->settings()->build_settings(),
+ GetNinjaFileForTarget(target));
out_ << "subninja ";
path_output_.WriteFile(out_, ninja_file);
out_ << std::endl;

Powered by Google App Engine
This is Rietveld 408576698