Chromium Code Reviews| Index: tools/gn/pattern.cc |
| diff --git a/tools/gn/pattern.cc b/tools/gn/pattern.cc |
| index 10ff5a436505d8c5ec3d5380fa4f14988cb557ad..ac3926065eaa1042001b8c1e9d6593b0948c1f4f 100644 |
| --- a/tools/gn/pattern.cc |
| +++ b/tools/gn/pattern.cc |
| @@ -167,16 +167,16 @@ void PatternList::SetFromValue(const Value& v, Err* err) { |
| } |
| const std::vector<Value>& list = v.list_value(); |
| - for (size_t i = 0; i < list.size(); i++) { |
| - if (!list[i].VerifyTypeIs(Value::STRING, err)) |
| + for (const auto& elem : list) { |
| + if (!elem.VerifyTypeIs(Value::STRING, err)) |
| return; |
| - patterns_.push_back(Pattern(list[i].string_value())); |
| + patterns_.push_back(Pattern(elem.string_value())); |
| } |
| } |
| bool PatternList::MatchesString(const std::string& s) const { |
| - for (size_t i = 0; i < patterns_.size(); i++) { |
| - if (patterns_[i].MatchesString(s)) |
| + for (const auto& pattern: patterns_) { |
|
scottmg
2015/03/23 17:24:20
nit; space before :
tfarina
2015/03/25 14:14:31
Done.
|
| + if (pattern.MatchesString(s)) |
| return true; |
| } |
| return false; |