Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: tools/gn/ninja_toolchain_writer.cc

Issue 986113002: tools/gn: Convert for loops to use the new range-based loops in C++11. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/ninja_toolchain_writer.h" 5 #include "tools/gn/ninja_toolchain_writer.h"
6 6
7 #include <fstream> 7 #include <fstream>
8 8
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/strings/stringize_macros.h" 10 #include "base/strings/stringize_macros.h"
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 const EscapeOptions& options) { 121 const EscapeOptions& options) {
122 if (pattern.empty()) 122 if (pattern.empty())
123 return; 123 return;
124 out_ << kIndent << name << " = "; 124 out_ << kIndent << name << " = ";
125 SubstitutionWriter::WriteWithNinjaVariables(pattern, options, out_); 125 SubstitutionWriter::WriteWithNinjaVariables(pattern, options, out_);
126 out_ << std::endl; 126 out_ << std::endl;
127 } 127 }
128 128
129 void NinjaToolchainWriter::WriteSubninjas() { 129 void NinjaToolchainWriter::WriteSubninjas() {
130 // Write subninja commands for each generated target. 130 // Write subninja commands for each generated target.
131 for (size_t i = 0; i < targets_.size(); i++) { 131 for (const auto& target: targets_) {
scottmg 2015/03/23 17:24:20 nit; space before :
tfarina 2015/03/25 14:14:31 Done.
132 OutputFile ninja_file(targets_[i]->settings()->build_settings(), 132 OutputFile ninja_file(target->settings()->build_settings(),
133 GetNinjaFileForTarget(targets_[i])); 133 GetNinjaFileForTarget(target));
134 out_ << "subninja "; 134 out_ << "subninja ";
135 path_output_.WriteFile(out_, ninja_file); 135 path_output_.WriteFile(out_, ninja_file);
136 out_ << std::endl; 136 out_ << std::endl;
137 } 137 }
138 out_ << std::endl; 138 out_ << std::endl;
139 } 139 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698