Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 985853002: Effen: willUmount->didUnmount, allow setState after didUnmount (Closed)

Created:
5 years, 9 months ago by rafaelw
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Effen: willUmount->didUnmount, allow setState after didUnmount This patch changes the timing of the unmount call until after the component is removed (and marked as such) and allows setState to be called after this point. If this happens, setState will still invoke the closer to do any neccesary cleanup, but doesn't schedule the component for render R=eseidel@chromium.org, eseidel BUG= Committed: https://chromium.googlesource.com/external/mojo/+/989d263a2ec47dec540a0ffe7b66df402807f8b5

Patch Set 1 #

Patch Set 2 : cr comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M sky/examples/fn/widgets/fixedheightscrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/fn/widgets/material.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/fn.dart View 1 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rafaelw
5 years, 9 months ago (2015-03-06 19:14:38 UTC) #2
eseidel
Seems fine, but why don't you want the _inRenderDirtyComponents safeguard? Should it now be ok ...
5 years, 9 months ago (2015-03-06 19:26:47 UTC) #3
eseidel
lgtm, but I suspect you want to leave my assert. You're welcome to remove it ...
5 years, 9 months ago (2015-03-06 19:27:09 UTC) #4
rafaelw
ok. fair enough. i added back the assert (but removed the early return on assertion ...
5 years, 9 months ago (2015-03-06 19:39:06 UTC) #5
rafaelw
5 years, 9 months ago (2015-03-06 20:24:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
989d263a2ec47dec540a0ffe7b66df402807f8b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698