sky/examples/fn/widgets/fixedheightscrollable.dart - Issue 985853002: Effen: willUmount->didUnmount, allow setState after didUnmount

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/examples/fn/widgets/fixedheightscrollable.dart

Issue 985853002: Effen: willUmount->didUnmount, allow setState after didUnmount (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: cr comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/examples/fn/widgets/fixedheightscrollable.dart

diff --git a/sky/examples/fn/widgets/fixedheightscrollable.dart b/sky/examples/fn/widgets/fixedheightscrollable.dart

index ecb558962ad1523ae25c4fafcfebefc02a585150..83733ea7c0b6cfe2716d7ba1ce1ef341bd3a1959 100644

--- a/sky/examples/fn/widgets/fixedheightscrollable.dart

+++ b/sky/examples/fn/widgets/fixedheightscrollable.dart

@@ -64,7 +64,7 @@ abstract class FixedHeightScrollable extends Component {

..events.listen('wheel', _handleWheel);

}

- void willUnmount() {

+ void didUnmount() {

_stopFling();

}

« no previous file with comments | « no previous file | sky/examples/fn/widgets/material.dart » ('j') | no next file with comments »