Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Side by Side Diff: sky/examples/fn/widgets/fixedheightscrollable.dart

Issue 985853002: Effen: willUmount->didUnmount, allow setState after didUnmount (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: cr comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/examples/fn/widgets/material.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 part of widgets; 1 part of widgets;
2 2
3 abstract class FixedHeightScrollable extends Component { 3 abstract class FixedHeightScrollable extends Component {
4 4
5 static Style _style = new Style(''' 5 static Style _style = new Style('''
6 overflow: hidden; 6 overflow: hidden;
7 position: relative; 7 position: relative;
8 will-change: transform;''' 8 will-change: transform;'''
9 ); 9 );
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 children: items 57 children: items
58 ) 58 )
59 ] 59 ]
60 ) 60 )
61 ..events.listen('gestureflingstart', _handleFlingStart) 61 ..events.listen('gestureflingstart', _handleFlingStart)
62 ..events.listen('gestureflingcancel', _handleFlingCancel) 62 ..events.listen('gestureflingcancel', _handleFlingCancel)
63 ..events.listen('gesturescrollupdate', _handleScrollUpdate) 63 ..events.listen('gesturescrollupdate', _handleScrollUpdate)
64 ..events.listen('wheel', _handleWheel); 64 ..events.listen('wheel', _handleWheel);
65 } 65 }
66 66
67 void willUnmount() { 67 void didUnmount() {
68 _stopFling(); 68 _stopFling();
69 } 69 }
70 70
71 bool _scrollBy(double scrollDelta) { 71 bool _scrollBy(double scrollDelta) {
72 var newScrollOffset = _scrollOffset + scrollDelta; 72 var newScrollOffset = _scrollOffset + scrollDelta;
73 if (minOffset != null && newScrollOffset < minOffset) { 73 if (minOffset != null && newScrollOffset < minOffset) {
74 newScrollOffset = minOffset; 74 newScrollOffset = minOffset;
75 } else if (maxOffset != null && newScrollOffset > maxOffset) { 75 } else if (maxOffset != null && newScrollOffset > maxOffset) {
76 newScrollOffset = maxOffset; 76 newScrollOffset = maxOffset;
77 } 77 }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 } 118 }
119 119
120 void _handleFlingCancel(sky.GestureEvent event) { 120 void _handleFlingCancel(sky.GestureEvent event) {
121 _stopFling(); 121 _stopFling();
122 } 122 }
123 123
124 void _handleWheel(sky.WheelEvent event) { 124 void _handleWheel(sky.WheelEvent event) {
125 _scrollBy(-event.offsetY); 125 _scrollBy(-event.offsetY);
126 } 126 }
127 } 127 }
OLDNEW
« no previous file with comments | « no previous file | sky/examples/fn/widgets/material.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698