base: Use more specific CHECK macros for comparisons.

base: Use more specific CHECK macros for comparisons.

Prefer DCHECK_EQ(a, b) over DCHECK(a == b) when possible as this
provides more data on a failure. Similar for other operators such as
>=, <, !=, etc.

This also applies to CHECK, EXPECT, and ASSERT macros.

R=Nico
BUG=464816
Committed: https://crrev.com/94219a212c616eac1914ca851c55256c4bbd9e36
Cr-Commit-Position: refs/heads/master@{#319751}

[Nico, 2015-03-06 23:08:47]

lgtm

https://codereview.chromium.org/985723003/diff/20001/base/posix/unix_domain_s...
File base/posix/unix_domain_socket_linux.cc (right):

https://codereview.chromium.org/985723003/diff/20001/base/posix/unix_domain_s...
base/posix/unix_domain_socket_linux.cc:140: DCHECK_EQ(wire_fds,
static_cast<void*>(nullptr));
wot? isn't nullptr supposed to work for all ptr types without casts?

[danakj, 2015-03-06 23:10:14]

https://codereview.chromium.org/985723003/diff/20001/base/posix/unix_domain_s...
File base/posix/unix_domain_socket_linux.cc (right):

https://codereview.chromium.org/985723003/diff/20001/base/posix/unix_domain_s...
base/posix/unix_domain_socket_linux.cc:140: DCHECK_EQ(wire_fds,
static_cast<void*>(nullptr));
On 2015/03/06 23:08:47, Nico wrote:
> wot? isn't nullptr supposed to work for all ptr types without casts?

It fails to have the right things for gtest iostream stuff. Or, maybe, gtest
fails to support nullptr.

[danakj, 2015-03-07 00:31:30]

Patchset #3 (id:40001) has been deleted

[danakj, 2015-03-07 00:31:38]

Patchset #3 (id:40001) has been deleted

[danakj, 2015-03-07 00:31:45]

Patchset #3 (id:60001) has been deleted

[danakj, 2015-03-07 00:59:12]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-07 00:59:13]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/985723003/#ps100001
(title: "basechecks: ios")

[danakj, 2015-03-07 00:59:23]

Patchset #3 (id:80001) has been deleted

[commit-bot: I haz the power, 2015-03-07 00:59:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985723003/100001

[commit-bot: I haz the power, 2015-03-07 01:05:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 01:05:39]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[danakj, 2015-03-09 22:23:06]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-09 22:23:06]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/985723003/#ps150001
(title: "basechecks: .")

[commit-bot: I haz the power, 2015-03-09 22:23:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985723003/150001

[commit-bot: I haz the power, 2015-03-09 22:27:49]

Committed patchset #6 (id:150001)

[commit-bot: I haz the power, 2015-03-09 22:29:44]

Patchset 6 (id:??) landed as
https://crrev.com/94219a212c616eac1914ca851c55256c4bbd9e36
Cr-Commit-Position: refs/heads/master@{#319751}