base/memory/discardable_memory_ashmem_allocator_unittest.cc - Issue 985723003: base: Use more specific CHECK macros for comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/discardable_memory_ashmem_allocator_unittest.cc

Issue 985723003: base: Use more specific CHECK macros for comparisons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: basechecks: . Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/discardable_memory_ashmem_allocator_unittest.cc

diff --git a/base/memory/discardable_memory_ashmem_allocator_unittest.cc b/base/memory/discardable_memory_ashmem_allocator_unittest.cc

index e9f63ba343963d5ecb0b479668db073568c44ac4..e6f2fea428c2ccc31bb332b162808fb865f8a3cd 100644

--- a/base/memory/discardable_memory_ashmem_allocator_unittest.cc

+++ b/base/memory/discardable_memory_ashmem_allocator_unittest.cc

@@ -85,7 +85,7 @@ TEST_F(DiscardableMemoryAshmemAllocatorTest,

scoped_ptr<DiscardableAshmemChunk> memory(allocator.Allocate(kPageSize));

ASSERT_TRUE(memory);

EXPECT_GT(kMaxAllowedAllocationSize, allocator.last_ashmem_region_size());

- ASSERT_TRUE(allocator.last_ashmem_region_size() % kPageSize == 0);

+ ASSERT_EQ(allocator.last_ashmem_region_size() % kPageSize, 0u);

}

TEST_F(DiscardableMemoryAshmemAllocatorTest, LargeAllocation) {

« no previous file with comments | « base/mac/scoped_mach_vm.cc ('k') | base/memory/shared_memory_posix.cc » ('j') | no next file with comments »