base/trace_event/process_memory_maps_dump_provider.cc - Issue 985723003: base: Use more specific CHECK macros for comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_maps_dump_provider.cc

Issue 985723003: base: Use more specific CHECK macros for comparisons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: basechecks: . Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/process_memory_maps_dump_provider.cc

diff --git a/base/trace_event/process_memory_maps_dump_provider.cc b/base/trace_event/process_memory_maps_dump_provider.cc

index 93feded9e80fe2ba6495d5526abbaf6cd743d719..fbe0eb1e8c32db46bffdd08cfaba96c32eb3087c 100644

--- a/base/trace_event/process_memory_maps_dump_provider.cc

+++ b/base/trace_event/process_memory_maps_dump_provider.cc

@@ -47,7 +47,7 @@ bool ParseSmapsHeader(std::istream* smaps,

region->protection_flags = 0;

*smaps >> protection_flags;

- CHECK(4UL == protection_flags.size());

+ CHECK_EQ(4UL, protection_flags.size());

if (protection_flags[0] == 'r') {

region->protection_flags |=

ProcessMemoryMaps::VMRegion::kProtectionFlagsRead;

« no previous file with comments | « base/time/time_win.cc ('k') | base/trace_event/trace_event_impl.cc » ('j') | no next file with comments »