chrome/installer/test/alternate_version_generator.cc - Issue 985573003: Support 32-bit subversion fields in base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/test/alternate_version_generator.cc

Issue 985573003: Support 32-bit subversion fields in base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a static assert Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/test/alternate_version_generator.cc

diff --git a/chrome/installer/test/alternate_version_generator.cc b/chrome/installer/test/alternate_version_generator.cc

index 98c72cf77e743d09116e60efcfa9bdee4ea531b6..e50c293ee0f34dc3ad01a840bb19669c74005144 100644

--- a/chrome/installer/test/alternate_version_generator.cc

+++ b/chrome/installer/test/alternate_version_generator.cc

@@ -111,7 +111,7 @@ class ChromeVersion {

static ChromeVersion FromString(const std::string& version_string) {

Version version(version_string);

DCHECK(version.IsValid());

- const std::vector<uint16>& c(version.components());

+ const std::vector<uint32_t>& c(version.components());

return ChromeVersion(static_cast<ULONGLONG>(c[0]) << 48 |

static_cast<ULONGLONG>(c[1]) << 32 |

static_cast<ULONGLONG>(c[2]) << 16 |