content/browser/gpu/gpu_data_manager_impl_private.cc - Issue 985573003: Support 32-bit subversion fields in base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private.cc

Issue 985573003: Support 32-bit subversion fields in base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a static assert Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/gpu/gpu_data_manager_impl_private.cc

diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc

index 06d083b7d9d6606162f8fcba2fe30e93f916ca28..c0e3fd69c8c763872130e94e9f541cfcdbe8a48b 100644

--- a/content/browser/gpu/gpu_data_manager_impl_private.cc

+++ b/content/browser/gpu/gpu_data_manager_impl_private.cc

@@ -77,7 +77,7 @@ int GetGpuBlacklistHistogramValueWin(GpuFeatureStatus status) {

version_str = version_str.substr(0, pos);

Version os_version(version_str);

if (os_version.IsValid() && os_version.components().size() >= 2) {

- const std::vector<uint16>& version_numbers = os_version.components();

+ const std::vector<uint32_t>& version_numbers = os_version.components();

if (version_numbers[0] == 5)

sub_version = kWinXP;

else if (version_numbers[0] == 6 && version_numbers[1] == 0)