chrome/installer/setup/install_worker.cc - Issue 985573003: Support 32-bit subversion fields in base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 985573003: Support 32-bit subversion fields in base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a static assert Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/setup/install_worker.cc

diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc

index d677f398c351a02491441fe132eb44ddc48a7e4b..5f7449f78809e8e3c558a400aaa6d715d8b9923a 100644

--- a/chrome/installer/setup/install_worker.cc

+++ b/chrome/installer/setup/install_worker.cc

@@ -669,7 +669,7 @@ void AddUninstallShortcutWorkItems(const InstallerState& installer_state,

InstallUtil::GetCurrentDate(),

false);

- const std::vector<uint16>& version_components = new_version.components();

+ const std::vector<uint32_t>& version_components = new_version.components();

if (version_components.size() == 4) {

// Our version should be in major.minor.build.rev.

install_list->AddSetRegValueWorkItem(