Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 98533003: Revert 238466 "Revert 238036 "Revert 238025 "Let test_isolation_..." (Closed)

Created:
7 years ago by Nico
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 238466 "Revert 238036 "Revert 238025 "Let test_isolation_..." While r238430 improved things, it didn't fix them enough. Exciting new error: OSError: File /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/<(mac_product_name) Framework.framework doesn't exist (tracked at http://crbug.com/324911) > Revert 238036 "Revert 238025 "Let test_isolation_mode default to..." > > The change was reverted because swarming didn't work with branded builds, > but r238430 should've fixed that. Relanding. (There are no branded trybots.) > > > Revert 238025 "Let test_isolation_mode default to check on mac." > > > > Failing on "Google Chrome Mac" (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/15042) > > In the error log, tools/swarming_client/isolate.py says "File /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Chromium Framework.framework doesn't exist" > > > > > Let test_isolation_mode default to check on mac. > > > > > > It was set to noop in https://chromiumcodereview.appspot.com/14055005 due to > > > issues with xcode. Now that xcode is no longer used, it can be set to check > > > again. > > > > > > BUG=none > > > > > > Review URL: https://codereview.chromium.org/92303002 > > > > TBR=thakis@chromium.org > > > > Review URL: https://codereview.chromium.org/98383002 > > TBR=hashimoto@chromium.org > > Review URL: https://codereview.chromium.org/102963003 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M trunk/src/build/common.gypi View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
7 years ago (2013-12-04 00:48:05 UTC) #1
Nico
7 years ago (2013-12-04 00:48:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r238505.

Powered by Google App Engine
This is Rietveld 408576698