Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 92303002: Let test_isolation_mode default to check on mac. (Closed)

Created:
7 years ago by Nico
Modified:
7 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, csharp
Visibility:
Public.

Description

Let test_isolation_mode default to check on mac. It was set to noop in https://chromiumcodereview.appspot.com/14055005 due to issues with xcode. Now that xcode is no longer used, it can be set to check again. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238025 R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/common.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
hooray?
7 years ago (2013-11-27 22:37:25 UTC) #1
Nico
ping
7 years ago (2013-11-30 22:35:09 UTC) #2
M-A Ruel
lgtm, sorry for the delay.
7 years ago (2013-12-02 00:02:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/92303002/1
7 years ago (2013-12-02 01:36:22 UTC) #4
commit-bot: I haz the power
Change committed as 238025
7 years ago (2013-12-02 04:28:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/92303002/1
7 years ago (2013-12-18 21:07:02 UTC) #6
Nico
Committed patchset #1 manually as r241681 (presubmit successful).
7 years ago (2013-12-18 22:19:37 UTC) #7
Vadim Sh.
7 years ago (2013-12-19 00:25:09 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/110693005/ by vadimsh@chromium.org.

The reason for reverting is: Broke Google Chrome Mac builder.

Powered by Google App Engine
This is Rietveld 408576698