Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 98383002: Revert 238025 "Let test_isolation_mode default to check on mac." (Closed)

Created:
7 years ago by hashimoto
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 238025 "Let test_isolation_mode default to check on mac." Failing on "Google Chrome Mac" (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/15042) In the error log, tools/swarming_client/isolate.py says "File /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Chromium Framework.framework doesn't exist" > Let test_isolation_mode default to check on mac. > > It was set to noop in https://chromiumcodereview.appspot.com/14055005 due to > issues with xcode. Now that xcode is no longer used, it can be set to check > again. > > BUG=none > > Review URL: https://codereview.chromium.org/92303002 TBR=thakis@chromium.org

Messages

Total messages: 4 (0 generated)
hashimoto
Oops, I was intended to delete another change on codereview.chromium.org but eventually deleted this change. ...
7 years ago (2013-12-02 06:12:26 UTC) #1
Nico
If this revert was not intentional, can you revert the revert? On Dec 1, 2013 ...
7 years ago (2013-12-02 06:16:54 UTC) #2
hashimoto
Deletion of the review issue was not intentional, but the revert was intentional. Sorry for ...
7 years ago (2013-12-02 06:19:55 UTC) #3
Nico
7 years ago (2013-12-02 06:21:15 UTC) #4
But after looking some more, this was probably the right cl to revert.
Don't reland it.
On Dec 1, 2013 10:16 PM, "Nico Weber" <thakis@chromium.org> wrote:

> If this revert was not intentional, can you revert the revert?
> On Dec 1, 2013 10:12 PM, "Ryo Hashimoto" <hashimoto@chromium.org> wrote:
>
>> Oops, I was intended to delete another change on
>> codereview.chromium.org but eventually deleted this change.
>> Really sorry.
>>
>> On Mon, Dec 2, 2013 at 3:07 PM,  <hashimoto@chromium.org> wrote:
>> > Committed patchset #1 manually as r238036.
>> >
>> > https://codereview.chromium.org/98383002/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698