chrome/renderer/extensions/extension_helper.h - Issue 9844008: Using DidCommitProvisionalLoad() instead of DidStartProvisionalLoad() in USIS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_helper.h

Issue 9844008: Using DidCommitProvisionalLoad() instead of DidStartProvisionalLoad() in USIS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/extensions/extension_helper.h

diff --git a/chrome/renderer/extensions/extension_helper.h b/chrome/renderer/extensions/extension_helper.h

index 29e9c6d3efe8f9a4d2b010deb53c7bd055eab9b6..f3acd4278b5fb1156d29dfe26f77ab3a1de2c663 100644

--- a/chrome/renderer/extensions/extension_helper.h

+++ b/chrome/renderer/extensions/extension_helper.h

@@ -56,7 +56,8 @@ class ExtensionHelper

virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;

virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE;

virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE;

- virtual void DidStartProvisionalLoad(WebKit::WebFrame* frame) OVERRIDE;

+ virtual void DidCommitProvisionalLoad(WebKit::WebFrame* frame,

+ bool is_new_navigation) OVERRIDE;

virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE;

virtual void DidCreateDataSource(WebKit::WebFrame* frame,

WebKit::WebDataSource* ds) OVERRIDE;

« no previous file with comments | « no previous file | chrome/renderer/extensions/extension_helper.cc » ('j') | no next file with comments »