content/browser/child_process_launcher.cc - Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_launcher.cc

Issue 983963002: Redefine base::Process:Terminate so that it can replace base::KillProcess (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add const Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/child_process_launcher.cc

diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc

index e5c93ee3562bbecd378d96c671d77c4fe219c39e..5a7be486f07814d5cb67fbfb65a039502363dc96 100644

--- a/content/browser/child_process_launcher.cc

+++ b/content/browser/child_process_launcher.cc

@@ -522,7 +522,7 @@ void ChildProcessLauncher::Context::TerminateInternal(

#else

// Client has gone away, so just kill the process. Using exit code 0

// means that UMA won't treat this as a crash.

- process.Terminate(RESULT_CODE_NORMAL_EXIT);

+ process.Terminate(RESULT_CODE_NORMAL_EXIT, false);

// On POSIX, we must additionally reap the child.

#if defined(OS_POSIX)

#if !defined(OS_MACOSX)

« no previous file with comments | « components/browser_watcher/exit_code_watcher_win_unittest.cc ('k') | net/tools/stress_cache/stress_cache.cc » ('j') | no next file with comments »