Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983833006: Remove uid and title from HeapSnapshot (Closed)

Created:
5 years, 9 months ago by yurys
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@cpu-profiling
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove uid and title from HeapSnapshot None of these fields is used in Blink. Embedder always can implement them using existing API. BUG=chromium:465651 LOG=Y Committed: https://crrev.com/619d4535cced3be482ea7f0a5ac1a31573e01119 Cr-Commit-Position: refs/heads/master@{#27113}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Updated tests #

Patch Set 4 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -197 lines) Patch
M include/v8-profiler.h View 1 2 3 3 chunks +9 lines, -8 lines 0 comments Download
M src/api.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M src/heap-profiler.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/heap-profiler.cc View 3 chunks +1 line, -11 lines 0 comments Download
M src/heap-snapshot-generator.h View 2 chunks +1 line, -7 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 54 chunks +72 lines, -140 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
yurys
5 years, 9 months ago (2015-03-10 10:15:20 UTC) #2
alph
lgtm https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h File include/v8-profiler.h (right): https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h#newcode453 include/v8-profiler.h:453: const HeapSnapshot* TakeHeapSnapshot( V8_DEPRECATED
5 years, 9 months ago (2015-03-10 10:23:26 UTC) #3
yurys
https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h File include/v8-profiler.h (right): https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h#newcode453 include/v8-profiler.h:453: const HeapSnapshot* TakeHeapSnapshot( On 2015/03/10 10:23:26, alph wrote: > ...
5 years, 9 months ago (2015-03-10 10:23:57 UTC) #4
yurys
Yang or Sven, please take a look.
5 years, 9 months ago (2015-03-10 10:37:36 UTC) #6
Yang
lgtm. https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h File include/v8-profiler.h (right): https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h#newcode453 include/v8-profiler.h:453: const HeapSnapshot* TakeHeapSnapshot( On 2015/03/10 10:23:57, yurys wrote: ...
5 years, 9 months ago (2015-03-10 10:38:12 UTC) #8
yurys
https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h File include/v8-profiler.h (right): https://codereview.chromium.org/983833006/diff/20001/include/v8-profiler.h#newcode453 include/v8-profiler.h:453: const HeapSnapshot* TakeHeapSnapshot( On 2015/03/10 10:38:11, Yang wrote: > ...
5 years, 9 months ago (2015-03-10 12:08:39 UTC) #9
Yang
lgtm
5 years, 9 months ago (2015-03-10 12:11:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983833006/60001
5 years, 9 months ago (2015-03-10 12:11:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/2257)
5 years, 9 months ago (2015-03-10 13:19:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983833006/60001
5 years, 9 months ago (2015-03-10 14:46:01 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-10 15:14:06 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:14:17 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/619d4535cced3be482ea7f0a5ac1a31573e01119
Cr-Commit-Position: refs/heads/master@{#27113}

Powered by Google App Engine
This is Rietveld 408576698