Remove uid and title from HeapSnapshot

include/v8-profiler.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_V8_PROFILER_H_
 #define V8_V8_PROFILER_H_
 
 #include "v8.h"
 
 /**
@@ skipping 295 matching lines @@
 
 /**
  * HeapSnapshots record the state of the JS heap at some moment.
  */
 class V8_EXPORT HeapSnapshot {
  public:
   enum SerializationFormat {
     kJSON = 0  // See format description near 'Serialize' method.
   };
 
-  /** Returns heap snapshot UID (assigned by the profiler.) */
-  unsigned GetUid() const;
-
-  /** Returns heap snapshot title. */
-  Handle<String> GetTitle() const;
-
   /** Returns the root node of the heap graph. */
   const HeapGraphNode* GetRoot() const;
 
   /** Returns a node by its id. */
   const HeapGraphNode* GetNodeById(SnapshotObjectId id) const;
 
   /** Returns total nodes count in the snapshot. */
   int GetNodesCount() const;
 
   /** Returns a node by index. */
@@ skipping 28 matching lines @@
    *      edge_count: nnn
    *    },
    *    nodes: [nodes array],
    *    edges: [edges array],
    *    strings: [strings array]
    *  }
    *
    * Nodes reference strings, other nodes, and edges by their indexes
    * in corresponding arrays.
    */
-  void Serialize(OutputStream* stream, SerializationFormat format) const;
+  void Serialize(OutputStream* stream,
+                 SerializationFormat format = kJSON) const;
 };
 
 
 /**
  * An interface for reporting progress and controlling long-running
  * activities.
  */
 class V8_EXPORT ActivityControl {  // NOLINT
  public:
   enum ControlOption {
@@ skipping 64 matching lines @@
     /**
      * Returns name to be used in the heap snapshot for given node. Returned
      * string must stay alive until snapshot collection is completed.
      */
     virtual const char* GetName(Handle<Object> object) = 0;
    protected:
     virtual ~ObjectNameResolver() {}
   };
 
   /**
-   * Takes a heap snapshot and returns it. Title may be an empty string.
+   * Takes a heap snapshot and returns it. Title parameter is deprecated and
+   * should be an empty string.
    */
   const HeapSnapshot* TakeHeapSnapshot(

[alph, 2015/03/10 10:23:26]

V8_DEPRECATED

[yurys, 2015/03/10 10:23:57]

I will need to fix Blink side first.

[Yang, 2015/03/10 10:38:11]

Please add a TODO.

[yurys, 2015/03/10 12:08:39]

Done.

       Handle<String> title,
       ActivityControl* control = NULL,
       ObjectNameResolver* global_object_name_resolver = NULL);
 
+  const HeapSnapshot* TakeHeapSnapshot(
+      ActivityControl* control = NULL,
+      ObjectNameResolver* global_object_name_resolver = NULL);
+
   /**
    * Starts tracking of heap objects population statistics. After calling
    * this method, all heap objects relocations done by the garbage collector
    * are being registered.
    *
    * |track_allocations| parameter controls whether stack trace of each
    * allocation in the heap will be recorded and reported as part of
    * HeapSnapshot.
    */
   void StartTrackingHeapObjects(bool track_allocations = false);
@@ skipping 137 matching lines @@
   uint32_t index;  // Index of the time interval that was changed.
   uint32_t count;  // New value of count field for the interval with this index.
   uint32_t size;  // New value of size field for the interval with this index.
 };
 
 
 }  // namespace v8
 
 
 #endif  // V8_V8_PROFILER_H_