Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: include/v8-profiler.h

Issue 983833006: Remove uid and title from HeapSnapshot (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@cpu-profiling
Patch Set: Addressed review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index 07f34e1385242e3bc95c7b9e7d1f935135a1b59a..56b8e02616a2d4594a1cb606c91cfd718e1fe920 100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -313,12 +313,6 @@ class V8_EXPORT HeapSnapshot {
kJSON = 0 // See format description near 'Serialize' method.
};
- /** Returns heap snapshot UID (assigned by the profiler.) */
- unsigned GetUid() const;
-
- /** Returns heap snapshot title. */
- Handle<String> GetTitle() const;
-
/** Returns the root node of the heap graph. */
const HeapGraphNode* GetRoot() const;
@@ -367,7 +361,8 @@ class V8_EXPORT HeapSnapshot {
* Nodes reference strings, other nodes, and edges by their indexes
* in corresponding arrays.
*/
- void Serialize(OutputStream* stream, SerializationFormat format) const;
+ void Serialize(OutputStream* stream,
+ SerializationFormat format = kJSON) const;
};
@@ -452,13 +447,19 @@ class V8_EXPORT HeapProfiler {
};
/**
- * Takes a heap snapshot and returns it. Title may be an empty string.
+ * Takes a heap snapshot and returns it. Title parameter is deprecated and
+ * should be an empty string.
+ * TODO: deprecate this method.
*/
const HeapSnapshot* TakeHeapSnapshot(
Handle<String> title,
ActivityControl* control = NULL,
ObjectNameResolver* global_object_name_resolver = NULL);
+ const HeapSnapshot* TakeHeapSnapshot(
+ ActivityControl* control = NULL,
+ ObjectNameResolver* global_object_name_resolver = NULL);
+
/**
* Starts tracking of heap objects population statistics. After calling
* this method, all heap objects relocations done by the garbage collector
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698