Allow changing a file from a part to a library.

Allow changing a file from a part to a library, and viceversa.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/60947ccfff35bf64b260cec54beb528fb7897552

[Siggi Cherem (dart-lang), 2015-03-05 01:28:47]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-03-05 01:30:13]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2015-03-05 01:30:59]

sigmund@google.com changed reviewers:
+ jmesserly@google.com

[Siggi Cherem (dart-lang), 2015-03-05 01:31:00]

to get this feature I had to merge libraries and parts as a single node, which
unfortunately make some other parts of the code a bit more complex.

[Jennifer Messerly, 2015-03-05 01:37:02]

lgtm

https://codereview.chromium.org/983553002/diff/40001/lib/src/dependency_graph...
File lib/src/dependency_graph.dart (right):

https://codereview.chromium.org/983553002/diff/40001/lib/src/dependency_graph...
lib/src/dependency_graph.dart:238: // previously a library file, and look just
for file changes.
just curious: how does the other direction work? part -> library?

https://codereview.chromium.org/983553002/diff/40001/test/dependency_graph_te...
File test/dependency_graph_test.dart (right):

https://codereview.chromium.org/983553002/diff/40001/test/dependency_graph_te...
test/dependency_graph_test.dart:201: test('change type', () {
maybe "change part -> library"

https://codereview.chromium.org/983553002/diff/40001/test/dependency_graph_te...
test/dependency_graph_test.dart:218: import 'a6.dart'; // changed from part
do we have tests for both directions for changes? part -> lib and lib -> part

[Siggi Cherem (dart-lang), 2015-03-06 18:46:25]

Patchset #2 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2015-03-06 18:46:29]

Patchset #2 (id:80001) has been deleted

[Siggi Cherem (dart-lang), 2015-03-06 18:50:26]

Patchset #2 (id:100001) has been deleted

[Siggi Cherem (dart-lang), 2015-03-06 18:52:07]

Thanks John. I ended up revisiting the changes a lot in order to address the
convertion back from parts to libraries, so the end result is quite different
than before. PTAL

https://codereview.chromium.org/983553002/diff/40001/lib/src/dependency_graph...
File lib/src/dependency_graph.dart (right):

https://codereview.chromium.org/983553002/diff/40001/lib/src/dependency_graph...
lib/src/dependency_graph.dart:238: // previously a library file, and look just
for file changes.
On 2015/03/05 01:37:01, John Messerly wrote:
> just curious: how does the other direction work? part -> library?

Good question - initially I was leaving the imports/exports/parts empty and
assume that the user would have to modify the file to get some imports in the
library in place.

Turns out that had a potential problem, it was sensitive to the order of the
operations. In particular, if you first edit the part and make it a library, and
then edit the library that included the part and switch there to include an
import, then we would have had an inconsistent graph.

After thinking more about it, I went ahead and changed the implementation.
Instead of clearing the imports here I'm tracking dependencies for parts, even
though we don't traverse them. That way, when we first switch over the directive
to an import, we'll notice it and can enqueue the work.

I added a bunch of tests now to cover all these transitions.

https://codereview.chromium.org/983553002/diff/40001/test/dependency_graph_te...
File test/dependency_graph_test.dart (right):

https://codereview.chromium.org/983553002/diff/40001/test/dependency_graph_te...
test/dependency_graph_test.dart:201: test('change type', () {
On 2015/03/05 01:37:01, John Messerly wrote:
> maybe "change part -> library"

Done.

https://codereview.chromium.org/983553002/diff/40001/test/dependency_graph_te...
test/dependency_graph_test.dart:218: import 'a6.dart'; // changed from part
On 2015/03/05 01:37:01, John Messerly wrote:
> do we have tests for both directions for changes? part -> lib and lib -> part

Added them now.

[Siggi Cherem (dart-lang), 2015-03-09 17:34:04]

friendly ping :)

[Jennifer Messerly, 2015-03-09 17:35:33]

lgtm

[Siggi Cherem (dart-lang), 2015-03-09 17:59:23]

Committed patchset #2 (id:120001) manually as
60947ccfff35bf64b260cec54beb528fb7897552 (presubmit successful).