Allow changing a file from a part to a library.

test/dependency_graph_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.test.dependency_graph_test;
 
 import 'package:unittest/compact_vm_config.dart';
 import 'package:unittest/unittest.dart';
 
 import 'package:dev_compiler/src/checker/dart_sdk.dart'
@@ skipping 37 matching lines @@
     '/a3.dart': 'library a3;',
     '/a4.dart': 'library a4; export "a10.dart";',
     '/a5.dart': 'library a5;',
     '/a6.dart': 'part of a2;',
     '/a7.dart': 'library a7;',
     '/a8.dart': 'library a8; import "a8.dart";',
     '/a9.dart': 'library a9; import "a8.dart";',
     '/a10.dart': 'library a10;',
   };
 
-  nodeOf(String filepath, [bool isPart = false]) =>
-      graph.nodeFromUri(new Uri.file(filepath), isPart);
+  nodeOf(String filepath) => graph.nodeFromUri(new Uri.file(filepath));
 
   setUp(() {
     /// We completely reset the TestUriResolver to avoid interference between
     /// tests (since some tests modify the state of the files).
     testUriResolver = new TestUriResolver(testFiles);
     context = new TypeResolver.fromMock(mockSdkSources, options,
         otherResolvers: [testUriResolver]).context;
     graph = new SourceGraph(context, options);
   });
 
@@ skipping 121 matching lines @@
           'import "a3.dart"; export "a7.dart"; part "a8.dart";';
       node.update(graph);
 
       expect(node.imports.length, 1);
       expect(node.exports.length, 1);
       expect(node.parts.length, 1);
       expect(node.imports.contains(nodeOf('/a3.dart')), isTrue);
       expect(node.exports.contains(nodeOf('/a7.dart')), isTrue);
       expect(node.parts.contains(nodeOf('/a8.dart')), isTrue);
     });
+
+    test('change type', () {

[Jennifer Messerly, 2015/03/05 01:37:01]

maybe "change part -> library"

[Siggi Cherem (dart-lang), 2015/03/06 18:52:06]

Done.

+      var node = nodeOf('/a2.dart');
+      node.update(graph);
+      expect(node.imports.length, 2);
+      expect(node.exports.length, 1);
+      expect(node.parts.length, 1);
+      expect(node.imports.contains(nodeOf('/a3.dart')), isTrue);
+      expect(node.imports.contains(nodeOf('/a4.dart')), isTrue);
+      expect(node.exports.contains(nodeOf('/a5.dart')), isTrue);
+      expect(node.parts.contains(nodeOf('/a6.dart')), isTrue);
+
+      node.source.contents.modificationTime++;
+      node.source.contents.data = '''
+          library a2;
+          import 'a3.dart';
+          import 'a4.dart';
+          export 'a5.dart';
+          import 'a6.dart'; // changed from part

[Jennifer Messerly, 2015/03/05 01:37:01]

do we have tests for both directions for changes? part -> lib and lib -> part

[Siggi Cherem (dart-lang), 2015/03/06 18:52:06]

Added them now.

+        ''';
+      var a6 = nodeOf('/a6.dart');
+      a6.source.contents.modificationTime++;
+      a6.source.contents.data = '';
+      node.update(graph);
+
+      expect(node.imports.length, 3);
+      expect(node.exports.length, 1);
+      expect(node.parts.length, 0);
+      expect(node.imports.contains(nodeOf('/a3.dart')), isTrue);
+      expect(node.imports.contains(nodeOf('/a4.dart')), isTrue);
+      expect(node.imports.contains(nodeOf('/a6.dart')), isTrue);
+      expect(node.exports.contains(nodeOf('/a5.dart')), isTrue);
+    });
   });
 
   group('local changes', () {
     group('needs rebuild', () {
       test('in HTML', () {
         var node = nodeOf('/index1.html');
         node.update(graph);
         expect(node.needsRebuild, isTrue);
         node.needsRebuild = false;
 
         node.update(graph);
         expect(node.needsRebuild, isFalse);
 
         // For now, an empty modification is enough to trigger a rebuild
         node.source.contents.modificationTime++;
         expect(node.needsRebuild, isFalse);
         node.update(graph);
         expect(node.needsRebuild, isTrue);
       });
 
       test('main library in Dart', () {
         var node = nodeOf('/a2.dart');
-        var partNode = nodeOf('/a6.dart', true);
+        var partNode = nodeOf('/a6.dart');
         node.update(graph);
         expect(node.needsRebuild, isTrue);
         node.needsRebuild = false;
         partNode.needsRebuild = false;
 
         node.update(graph);
         expect(node.needsRebuild, isFalse);
 
         // For now, an empty modification is enough to trigger a rebuild
         node.source.contents.modificationTime++;
         expect(node.needsRebuild, isFalse);
         node.update(graph);
         expect(node.needsRebuild, isTrue);
       });
 
       test('part of library in Dart', () {
         var node = nodeOf('/a2.dart');
         var importNode = nodeOf('/a3.dart');
         var exportNode = nodeOf('/a5.dart');
-        var partNode = nodeOf('/a6.dart', true);
+        var partNode = nodeOf('/a6.dart');
         node.update(graph);
         expect(node.needsRebuild, isTrue);
         node.needsRebuild = false;
         partNode.needsRebuild = false;
 
         node.update(graph);
         expect(node.needsRebuild, isFalse);
 
         // Modification in imported/exported node makes no difference for local
         // rebuild label (globally that's tested elsewhere)
@@ skipping 54 matching lines @@
         expect(node.structureChanged, isFalse);
         node.update(graph);
         expect(node.structureChanged, isTrue);
         expect(node.scripts.length, 2);
       });
 
       test('no mod in Dart', () {
         var node = nodeOf('/a2.dart');
         var importNode = nodeOf('/a3.dart');
         var exportNode = nodeOf('/a5.dart');
-        var partNode = nodeOf('/a6.dart', true);
+        var partNode = nodeOf('/a6.dart');
         node.update(graph);
         expect(node.structureChanged, isTrue);
         node.structureChanged = false;
 
         node.update(graph);
         expect(node.structureChanged, isFalse);
 
         // These modifications make no difference at all.
         importNode.source.contents.modificationTime++;
         exportNode.source.contents.modificationTime++;
@@ skipping 406 matching lines @@
     if (seen.contains(n)) {
       sb.write('...\n');
       return;
     }
     seen.add(n);
     sb
       ..write(' ')
       ..write(n.needsRebuild ? '[needs-rebuild] ' : '')
       ..write(n.structureChanged ? '[structure-changed] ' : ' ')
       ..write('\n');
-    n.directDeps.forEach((e) => helper(e, indent: indent + 1));
+    n.allDeps.forEach((e) => helper(e, indent: indent + 1));
   }
   helper(node);
   return sb.toString();
 }
 
 bool _same(Set a, Set b) => a.length == b.length && a.containsAll(b);