Allow changing a file from a part to a library.

test/dependency_graph_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.test.dependency_graph_test;
 
 import 'package:unittest/compact_vm_config.dart';
 import 'package:unittest/unittest.dart';
 
 import 'package:dev_compiler/src/checker/dart_sdk.dart'
@@ skipping 37 matching lines @@
     '/a3.dart': 'library a3;',
     '/a4.dart': 'library a4; export "a10.dart";',
     '/a5.dart': 'library a5;',
     '/a6.dart': 'part of a2;',
     '/a7.dart': 'library a7;',
     '/a8.dart': 'library a8; import "a8.dart";',
     '/a9.dart': 'library a9; import "a8.dart";',
     '/a10.dart': 'library a10;',
   };
 
-  nodeOf(String filepath, [bool isPart = false]) =>
-      graph.nodeFromUri(new Uri.file(filepath), isPart);
+  nodeOf(String filepath) => graph.nodeFromUri(new Uri.file(filepath));
 
   setUp(() {
     /// We completely reset the TestUriResolver to avoid interference between
     /// tests (since some tests modify the state of the files).
     testUriResolver = new TestUriResolver(testFiles);
     context = new TypeResolver.fromMock(mockSdkSources, options,
         otherResolvers: [testUriResolver]).context;
     graph = new SourceGraph(context, options);
   });
 
@@ skipping 121 matching lines @@
           'import "a3.dart"; export "a7.dart"; part "a8.dart";';
       node.update(graph);
 
       expect(node.imports.length, 1);
       expect(node.exports.length, 1);
       expect(node.parts.length, 1);
       expect(node.imports.contains(nodeOf('/a3.dart')), isTrue);
       expect(node.exports.contains(nodeOf('/a7.dart')), isTrue);
       expect(node.parts.contains(nodeOf('/a8.dart')), isTrue);
     });
+
+    test('change part to library', () {
+      var node = nodeOf('/a2.dart');
+      node.update(graph);
+      expect(node.imports.length, 2);
+      expect(node.exports.length, 1);
+      expect(node.parts.length, 1);
+      expect(node.imports.contains(nodeOf('/a3.dart')), isTrue);
+      expect(node.imports.contains(nodeOf('/a4.dart')), isTrue);
+      expect(node.exports.contains(nodeOf('/a5.dart')), isTrue);
+      expect(node.parts.contains(nodeOf('/a6.dart')), isTrue);
+
+      node.source.contents.modificationTime++;
+      node.source.contents.data = '''
+          library a2;
+          import 'a3.dart';
+          import 'a4.dart';
+          export 'a5.dart';
+          import 'a6.dart'; // changed from part
+        ''';
+      var a6 = nodeOf('/a6.dart');
+      a6.source.contents.modificationTime++;
+      a6.source.contents.data = '';
+      node.update(graph);
+
+      expect(node.imports.length, 3);
+      expect(node.exports.length, 1);
+      expect(node.parts.length, 0);
+      expect(node.imports.contains(nodeOf('/a3.dart')), isTrue);
+      expect(node.imports.contains(nodeOf('/a4.dart')), isTrue);
+      expect(node.imports.contains(nodeOf('/a6.dart')), isTrue);
+      expect(node.exports.contains(nodeOf('/a5.dart')), isTrue);
+
+      expect(a6.imports.length, 0);
+      expect(a6.exports.length, 0);
+      expect(a6.parts.length, 0);
+    });
+
+    test('change library to part', () {
+      var node = nodeOf('/a2.dart');
+      var a4 = nodeOf('/a4.dart');
+      node.update(graph);
+      expect(node.imports.length, 2);
+      expect(node.exports.length, 1);
+      expect(node.parts.length, 1);
+      expect(node.imports.contains(nodeOf('/a3.dart')), isTrue);
+      expect(node.imports.contains(nodeOf('/a4.dart')), isTrue);
+      expect(node.exports.contains(nodeOf('/a5.dart')), isTrue);
+      expect(node.parts.contains(nodeOf('/a6.dart')), isTrue);
+
+      a4.update(graph);
+      expect(a4.imports.length, 0);
+      expect(a4.exports.length, 1);
+      expect(a4.parts.length, 0);
+
+      node.source.contents.modificationTime++;
+      node.source.contents.data = '''
+          library a2;
+          import 'a3.dart';
+          part 'a4.dart'; // changed from export
+          export 'a5.dart';
+          part 'a6.dart';
+        ''';
+      node.update(graph);
+
+      expect(node.imports.length, 1);
+      expect(node.exports.length, 1);
+      expect(node.parts.length, 2);
+      expect(node.imports.contains(nodeOf('/a3.dart')), isTrue);
+      expect(node.exports.contains(nodeOf('/a5.dart')), isTrue);
+      expect(node.parts.contains(nodeOf('/a4.dart')), isTrue);
+      expect(node.parts.contains(nodeOf('/a6.dart')), isTrue);
+
+      // Note, technically we never modified the contents of a4 and it contains
+      // an export. This is invalid Dart, but we'll let the analyzer report that
+      // error instead of doing so ourselves.
+      expect(a4.imports.length, 0);
+      expect(a4.exports.length, 1);
+      expect(a4.parts.length, 0);
+
+      // And change it back.
+      node.source.contents.modificationTime++;
+      node.source.contents.data = '''
+          library a2;
+          import 'a3.dart';
+          import 'a4.dart'; // changed again
+          export 'a5.dart';
+          part 'a6.dart';
+        ''';
+      node.update(graph);
+      expect(node.imports.contains(a4), isTrue);
+      expect(a4.imports.length, 0);
+      expect(a4.exports.length, 1);
+      expect(a4.parts.length, 0);
+    });
   });
 
   group('local changes', () {
     group('needs rebuild', () {
       test('in HTML', () {
         var node = nodeOf('/index1.html');
         node.update(graph);
         expect(node.needsRebuild, isTrue);
         node.needsRebuild = false;
 
         node.update(graph);
         expect(node.needsRebuild, isFalse);
 
         // For now, an empty modification is enough to trigger a rebuild
         node.source.contents.modificationTime++;
         expect(node.needsRebuild, isFalse);
         node.update(graph);
         expect(node.needsRebuild, isTrue);
       });
 
       test('main library in Dart', () {
         var node = nodeOf('/a2.dart');
-        var partNode = nodeOf('/a6.dart', true);
+        var partNode = nodeOf('/a6.dart');
         node.update(graph);
         expect(node.needsRebuild, isTrue);
         node.needsRebuild = false;
         partNode.needsRebuild = false;
 
         node.update(graph);
         expect(node.needsRebuild, isFalse);
 
         // For now, an empty modification is enough to trigger a rebuild
         node.source.contents.modificationTime++;
         expect(node.needsRebuild, isFalse);
         node.update(graph);
         expect(node.needsRebuild, isTrue);
       });
 
       test('part of library in Dart', () {
         var node = nodeOf('/a2.dart');
         var importNode = nodeOf('/a3.dart');
         var exportNode = nodeOf('/a5.dart');
-        var partNode = nodeOf('/a6.dart', true);
+        var partNode = nodeOf('/a6.dart');
         node.update(graph);
         expect(node.needsRebuild, isTrue);
         node.needsRebuild = false;
         partNode.needsRebuild = false;
 
         node.update(graph);
         expect(node.needsRebuild, isFalse);
 
         // Modification in imported/exported node makes no difference for local
         // rebuild label (globally that's tested elsewhere)
@@ skipping 54 matching lines @@
         expect(node.structureChanged, isFalse);
         node.update(graph);
         expect(node.structureChanged, isTrue);
         expect(node.scripts.length, 2);
       });
 
       test('no mod in Dart', () {
         var node = nodeOf('/a2.dart');
         var importNode = nodeOf('/a3.dart');
         var exportNode = nodeOf('/a5.dart');
-        var partNode = nodeOf('/a6.dart', true);
+        var partNode = nodeOf('/a6.dart');
         node.update(graph);
         expect(node.structureChanged, isTrue);
         node.structureChanged = false;
 
         node.update(graph);
         expect(node.structureChanged, isFalse);
 
         // These modifications make no difference at all.
         importNode.source.contents.modificationTime++;
         exportNode.source.contents.modificationTime++;
@@ skipping 129 matching lines @@
       var node = nodeOf('/index3.html');
       expectGraph(node, 'index3.html');
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html [needs-rebuild] [structure-changed]
           |-- a2.dart [needs-rebuild] [structure-changed]
           |    |-- a3.dart [needs-rebuild]
           |    |-- a4.dart [needs-rebuild] [structure-changed]
           |    |    |-- a10.dart [needs-rebuild]
           |    |-- a5.dart [needs-rebuild]
-          |    |-- a6.dart [needs-rebuild]
+          |    |-- a6.dart (part) [needs-rebuild]
           ''');
     });
 
     test('cleared marks stay clear', () {
       var node = nodeOf('/index3.html');
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html [needs-rebuild] [structure-changed]
           |-- a2.dart [needs-rebuild] [structure-changed]
           |    |-- a3.dart [needs-rebuild]
           |    |-- a4.dart [needs-rebuild] [structure-changed]
           |    |    |-- a10.dart [needs-rebuild]
           |    |-- a5.dart [needs-rebuild]
-          |    |-- a6.dart [needs-rebuild]
+          |    |-- a6.dart (part) [needs-rebuild]
           ''');
       clearMarks(node);
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart
-          |    |-- a6.dart
+          |    |-- a6.dart (part)
           ''');
 
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart
-          |    |-- a6.dart
+          |    |-- a6.dart (part)
           ''');
     });
 
     test('needsRebuild mark updated on local modifications', () {
       var node = nodeOf('/index3.html');
       refreshStructureAndMarks(node, graph);
       clearMarks(node);
       var a3 = nodeOf('/a3.dart');
       a3.source.contents.modificationTime++;
 
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart [needs-rebuild]
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart
-          |    |-- a6.dart
+          |    |-- a6.dart (part)
           ''');
     });
 
     test('structuredChanged mark updated on structure modifications', () {
       var node = nodeOf('/index3.html');
       refreshStructureAndMarks(node, graph);
       clearMarks(node);
       var a5 = nodeOf('/a5.dart');
       a5.source.contents.modificationTime++;
       a5.source.contents.data = 'import "a8.dart";';
 
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart [needs-rebuild] [structure-changed]
           |    |    |-- a8.dart [needs-rebuild] [structure-changed]
           |    |    |    |-- a8.dart...
-          |    |-- a6.dart
+          |    |-- a6.dart (part)
           ''');
     });
   });
 
   group('rebuild', () {
     var results;
     void addName(SourceNode n) => results.add(nameFor(n));
 
     bool buildNoTransitiveChange(SourceNode n) {
       addName(n);
@@ skipping 23 matching lines @@
       ]);
 
       // Marks are removed automatically by rebuild
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart
-          |    |-- a6.dart
+          |    |-- a6.dart (part)
           ''');
     });
 
     test('nothing to do after build', () {
       var node = nodeOf('/index3.html');
       rebuild(node, graph, buildNoTransitiveChange);
 
       results = [];
       rebuild(node, graph, buildNoTransitiveChange);
       expect(results, []);
@@ skipping 108 matching lines @@
       a2.source.contents.modificationTime++;
       a2.source.contents.data = 'import "a9.dart";';
 
       rebuild(node, graph, buildNoTransitiveChange);
       expect(results, ['a8.dart', 'a9.dart', 'a2.dart', 'index3.html']);
 
       results = [];
       rebuild(node, graph, buildNoTransitiveChange);
       expect(results, []);
     });
+
+    group('file upgrades', () {
+      // Normally upgrading involves two changes:
+      //  (a) change the affected file
+      //  (b) change directive from part to import (or viceversa)
+      // These could happen in any order and we should reach a consistent state
+      // in the end.
+
+      test('convert part to a library before updating the import', () {
+        var node = nodeOf('/index3.html');
+        var a2 = nodeOf('/a2.dart');
+        var a6 = nodeOf('/a6.dart');
+        rebuild(node, graph, buildNoTransitiveChange);
+
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a5.dart
+            |    |-- a6.dart (part)
+            ''');
+
+        // Modify the file first:
+        a6.source.contents.modificationTime++;
+        a6.source.contents.data = 'library a6; import "a5.dart";';
+        results = [];
+        rebuild(node, graph, buildNoTransitiveChange);
+
+        // Looks to us like a change in a part, we'll report errors that the
+        // part is not really a part-file. Note that a6.dart is not included
+        // below, because we don't build it as a library.
+        expect(results, ['a2.dart']);
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a5.dart
+            |    |-- a6.dart (part)
+            ''');
+
+        a2.source.contents.modificationTime++;
+        a2.source.contents.data = '''
+            library a2;
+            import 'a3.dart';
+            import 'a4.dart';
+            import 'a6.dart'; // properly import it
+            export 'a5.dart';
+          ''';
+        results = [];
+        rebuild(node, graph, buildNoTransitiveChange);
+        // Note that a6 is now included, because we haven't built it as a
+        // library until now:
+        expect(results, ['a6.dart', 'a2.dart', 'index3.html']);
+
+        a6.source.contents.modificationTime++;
+        results = [];
+        rebuild(node, graph, buildNoTransitiveChange);
+        expect(results, ['a6.dart']);
+
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a6.dart
+            |    |    |-- a5.dart
+            |    |-- a5.dart...
+            ''');
+      });
+
+      test('convert part to a library after updating the import', () {
+        var node = nodeOf('/index3.html');
+        var a2 = nodeOf('/a2.dart');
+        var a6 = nodeOf('/a6.dart');
+        rebuild(node, graph, buildNoTransitiveChange);
+
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a5.dart
+            |    |-- a6.dart (part)
+            ''');
+
+        a2.source.contents.modificationTime++;
+        a2.source.contents.data = '''
+            library a2;
+            import 'a3.dart';
+            import 'a4.dart';
+            import 'a6.dart'; // properly import it
+            export 'a5.dart';
+          ''';
+        results = [];
+        rebuild(node, graph, buildNoTransitiveChange);
+        expect(results, ['a6.dart', 'a2.dart', 'index3.html']);
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a6.dart
+            |    |-- a5.dart
+            ''');
+
+        a6.source.contents.modificationTime++;
+        a6.source.contents.data = 'library a6; import "a5.dart";';
+        results = [];
+        rebuild(node, graph, buildNoTransitiveChange);
+        expect(results, ['a6.dart', 'index3.html']);
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a6.dart
+            |    |    |-- a5.dart
+            |    |-- a5.dart...
+            ''');
+      });
+
+      test('disconnect part making it a library', () {
+        var node = nodeOf('/index3.html');
+        var a2 = nodeOf('/a2.dart');
+        var a6 = nodeOf('/a6.dart');
+        rebuild(node, graph, buildNoTransitiveChange);
+
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a5.dart
+            |    |-- a6.dart (part)
+            ''');
+
+        a2.source.contents.modificationTime++;
+        a2.source.contents.data = '''
+            library a2;
+            import 'a3.dart';
+            import 'a4.dart';
+            export 'a5.dart';
+          ''';
+        a6.source.contents.modificationTime++;
+        a6.source.contents.data = 'library a6; import "a5.dart";';
+        results = [];
+        rebuild(node, graph, buildNoTransitiveChange);
+        // a6 is not here, it's not reachable so we don't build it.
+        expect(results, ['a2.dart', 'index3.html']);
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a5.dart
+            ''');
+      });
+
+      test('convert a library to a part', () {
+        var node = nodeOf('/index3.html');
+        var a2 = nodeOf('/a2.dart');
+        var a5 = nodeOf('/a5.dart');
+        rebuild(node, graph, buildNoTransitiveChange);
+
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a5.dart
+            |    |-- a6.dart (part)
+            ''');
+
+        a2.source.contents.modificationTime++;
+        a2.source.contents.data = '''
+            library a2;
+            import 'a3.dart';
+            import 'a4.dart';
+            part 'a5.dart'; // make it a part
+            part 'a6.dart';
+          ''';
+        results = [];
+        rebuild(node, graph, buildNoTransitiveChange);
+        expect(results, ['a2.dart', 'index3.html']);
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a5.dart (part)
+            |    |-- a6.dart (part)
+            ''');
+
+        a5.source.contents.modificationTime++;
+        a5.source.contents.data = 'part of a2;';
+        results = [];
+        rebuild(node, graph, buildNoTransitiveChange);
+        expect(results, ['a2.dart']);
+        expectGraph(node, '''
+            index3.html
+            |-- a2.dart
+            |    |-- a3.dart
+            |    |-- a4.dart
+            |    |    |-- a10.dart
+            |    |-- a5.dart (part)
+            |    |-- a6.dart (part)
+            ''');
+      });
+    });
   });
 }
 
 expectGraph(SourceNode node, String expectation) {
   expect(printReachable(node), equalsIgnoringWhitespace(expectation));
 }
 
 nameFor(SourceNode node) => path.basename(node.uri.path);
 printReachable(SourceNode node) {
   var seen = new Set();
   var sb = new StringBuffer();
   helper(n, {indent: 0}) {
     if (indent > 0) {
       sb
         ..write("|   " * (indent - 1))
         ..write("|-- ");
     }
     sb.write(nameFor(n));
     if (seen.contains(n)) {
       sb.write('...\n');
       return;
     }
     seen.add(n);
     sb
       ..write(' ')
       ..write(n.needsRebuild ? '[needs-rebuild] ' : '')
       ..write(n.structureChanged ? '[structure-changed] ' : ' ')
       ..write('\n');
-    n.directDeps.forEach((e) => helper(e, indent: indent + 1));
+    n.depsWithoutParts.forEach((e) => helper(e, indent: indent + 1));
+    if (n is DartSourceNode) {
+      n.parts.forEach((e) {
+        sb
+          ..write("|   " * indent)
+          ..write("|--  ")
+          ..write(nameFor(e))
+          ..write(" (part) ")
+          ..write(e.needsRebuild ? '[needs-rebuild] ' : '')
+          ..write(e.structureChanged ? '[structure-changed] ' : ' ')
+          ..write('\n');
+      });
+    }
   }
   helper(node);
   return sb.toString();
 }
 
 bool _same(Set a, Set b) => a.length == b.length && a.containsAll(b);