Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983103004: win: fixes for Windows x64 (Closed)

Created:
5 years, 9 months ago by scottmg
Modified:
5 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: fixes for Windows x64 Mostly size_t <-> unsigned int warnings, but I also had a mistake in PROCESS_BASIC_INFORMATION, the pids are 32-on-32 and 64-on-64. The Windows build is still x86 until https://codereview.chromium.org/981333002/. I don't think I'll bother maintaining the x86 build for now, though we will probably need it for x86 OSs in the future. It should be straightforward to revive it once we need it, and have bots to support it. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/07fcf63c2183ffc23566ac03ab3ebe0d4d77a326

Patch Set 1 #

Patch Set 2 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -54 lines) Patch
M client/crash_report_database_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M compat/win/sys/types.h View 1 chunk +5 lines, -2 lines 0 comments Download
M minidump/minidump_exception_writer.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M minidump/minidump_exception_writer_test.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M minidump/minidump_file_writer.h View 2 chunks +2 lines, -1 line 0 comments Download
M minidump/minidump_file_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_memory_writer.h View 2 chunks +2 lines, -1 line 0 comments Download
M minidump/minidump_memory_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_crashpad_info_writer_test.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M minidump/minidump_module_writer.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M minidump/minidump_thread_id_map.cc View 2 chunks +3 lines, -1 line 0 comments Download
M minidump/minidump_writable.h View 3 chunks +3 lines, -2 lines 0 comments Download
M minidump/minidump_writable.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M minidump/minidump_writable_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M minidump/test/minidump_memory_writer_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M minidump/test/minidump_memory_writer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/test/minidump_rva_list_test_util.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M snapshot/minidump/process_snapshot_minidump_test.cc View 1 3 chunks +8 lines, -6 lines 0 comments Download
M snapshot/win/process_reader_win.h View 2 chunks +3 lines, -2 lines 0 comments Download
M snapshot/win/process_reader_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M util/net/http_multipart_builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M util/net/http_transport_win.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M util/win/process_info.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 9 months ago (2015-03-06 20:03:07 UTC) #1
Mark Mentovai
LGTM
5 years, 9 months ago (2015-03-06 23:41:55 UTC) #2
scottmg
5 years, 9 months ago (2015-03-07 00:05:42 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
07fcf63c2183ffc23566ac03ab3ebe0d4d77a326 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698