minidump/minidump_exception_writer.cc - Issue 983103004: win: fixes for Windows x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_exception_writer.cc

Issue 983103004: win: fixes for Windows x64 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: mac Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_exception_writer.cc

diff --git a/minidump/minidump_exception_writer.cc b/minidump/minidump_exception_writer.cc

index 87382b22d366ff8442fa38f0afa7bc30ded95502..3d0c3414d088f37542e5a1b8c13e1e55496fe5ac 100644

--- a/minidump/minidump_exception_writer.cc

+++ b/minidump/minidump_exception_writer.cc

@@ -17,6 +17,7 @@

#include <sys/types.h>

#include "base/logging.h"

+#include "base/numerics/safe_conversions.h"

#include "minidump/minidump_context_writer.h"

#include "snapshot/exception_snapshot.h"

#include "util/file/file_writer.h"

@@ -66,7 +67,8 @@ void MinidumpExceptionWriter::SetExceptionInformation(

arraysize(exception_.ExceptionRecord.ExceptionInformation);

CHECK_LE(parameters, kMaxParameters);

- exception_.ExceptionRecord.NumberParameters = parameters;

+ exception_.ExceptionRecord.NumberParameters =

+ base::checked_cast<uint32_t>(parameters);

size_t parameter = 0;

for (; parameter < parameters; ++parameter) {

exception_.ExceptionRecord.ExceptionInformation[parameter] =

« no previous file with comments | « compat/win/sys/types.h ('k') | minidump/minidump_exception_writer_test.cc » ('j') | no next file with comments »