Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: snapshot/minidump/process_snapshot_minidump_test.cc

Issue 983103004: win: fixes for Windows x64 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: mac Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/test/minidump_rva_list_test_util.cc ('k') | snapshot/win/process_reader_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/minidump/process_snapshot_minidump_test.cc
diff --git a/snapshot/minidump/process_snapshot_minidump_test.cc b/snapshot/minidump/process_snapshot_minidump_test.cc
index a214309ef49e2034dee6f96651b46734ef592e66..12cdd7905796e0d13e5a05a34ffbc2da18fbf03a 100644
--- a/snapshot/minidump/process_snapshot_minidump_test.cc
+++ b/snapshot/minidump/process_snapshot_minidump_test.cc
@@ -63,7 +63,7 @@ TEST(ProcessSnapshotMinidump, Empty) {
RVA WriteString(FileWriterInterface* writer, const std::string& string) {
RVA rva = static_cast<RVA>(writer->SeekGet());
- uint32_t string_size = string.size();
+ uint32_t string_size = static_cast<uint32_t>(string.size());
EXPECT_TRUE(writer->Write(&string_size, sizeof(string_size)));
// Include the trailing NUL character.
@@ -88,16 +88,17 @@ void WriteMinidumpSimpleStringDictionary(
location->Rva = static_cast<RVA>(writer->SeekGet());
- const uint32_t simple_string_dictionary_entries = entries.size();
+ const uint32_t simple_string_dictionary_entries =
+ static_cast<uint32_t>(entries.size());
EXPECT_TRUE(writer->Write(&simple_string_dictionary_entries,
sizeof(simple_string_dictionary_entries)));
for (const MinidumpSimpleStringDictionaryEntry& entry : entries) {
EXPECT_TRUE(writer->Write(&entry, sizeof(entry)));
}
- location->DataSize =
+ location->DataSize = static_cast<uint32_t>(
sizeof(simple_string_dictionary_entries) +
- entries.size() * sizeof(MinidumpSimpleStringDictionaryEntry);
+ entries.size() * sizeof(MinidumpSimpleStringDictionaryEntry));
}
// Writes |strings| to |writer| as a MinidumpRVAList referencing
@@ -113,13 +114,14 @@ void WriteMinidumpStringList(MINIDUMP_LOCATION_DESCRIPTOR* location,
location->Rva = static_cast<RVA>(writer->SeekGet());
- const uint32_t string_list_entries = rvas.size();
+ const uint32_t string_list_entries = static_cast<uint32_t>(rvas.size());
EXPECT_TRUE(writer->Write(&string_list_entries, sizeof(string_list_entries)));
for (RVA rva : rvas) {
EXPECT_TRUE(writer->Write(&rva, sizeof(rva)));
}
- location->DataSize = sizeof(string_list_entries) + rvas.size() * sizeof(RVA);
+ location->DataSize = static_cast<uint32_t>(sizeof(string_list_entries) +
+ rvas.size() * sizeof(RVA));
}
TEST(ProcessSnapshotMinidump, AnnotationsSimpleMap) {
« no previous file with comments | « minidump/test/minidump_rva_list_test_util.cc ('k') | snapshot/win/process_reader_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698