Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 983103003: Use Length for the stroke-width property in SVGLayoutStyle (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-rendering, blink-reviews-style_chromium.org, dglazkov+blink, Dominik Röttsches, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, Mike Lawther (Google), pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use Length for the stroke-width property in SVGLayoutStyle Straight-forward if it hadn't been for the default value - "1" - which does not interact well with the zoom (is not affected by it). To deal with that, introduce a helper wrapper - UnzoomedLength - and use that instead of a plain Length. The animation framework is changed to use AnimatedLength and LengthStyleInterpolation. This leaves AnimatedSVGLength and SVGLengthStyleInterpolation unused, so they are removed. BUG=461375 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191544

Patch Set 1 #

Patch Set 2 : Remove SVGLengthStyleInterpolation; Fix (unused) type in SVGLayoutStyleTest UT. #

Patch Set 3 : Adjust transitions/svg-transitions.html #

Total comments: 1

Patch Set 4 : lengthSetterForProperty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -474 lines) Patch
M LayoutTests/animations/interpolation/svg-stroke-width-interpolation.html View 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-width-interpolation-expected.txt View 2 chunks +18 lines, -18 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/transitions/svg-transitions.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/transitions/svg-transitions-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
D Source/core/animation/SVGLengthStyleInterpolation.h View 1 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/animation/SVGLengthStyleInterpolation.cpp View 1 1 chunk +0 lines, -85 lines 0 comments Download
D Source/core/animation/SVGLengthStyleInterpolationTest.cpp View 1 1 chunk +0 lines, -71 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 2 3 4 chunks +2 lines, -8 lines 0 comments Download
D Source/core/animation/animatable/AnimatableSVGLength.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/animation/animatable/AnimatableSVGLength.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueTestHelper.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueTestHelper.cpp View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 2 3 4 chunks +13 lines, -4 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/LayoutStyleCSSValueMapping.cpp View 2 chunks +9 lines, -1 line 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 4 chunks +13 lines, -12 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 3 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/style/LayoutStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.h View 5 chunks +6 lines, -12 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/style/SVGLayoutStyleDefs.h View 3 chunks +16 lines, -2 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyleDefs.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyleTest.cpp View 1 2 chunks +1 line, -15 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGShape.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGText.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/LinearGradientAttributes.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/RadialGradientAttributes.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGLengthContext.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 1 2 3 2 chunks +16 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
fs
I guess you know the drill by now ;-) - this is the last one ...
5 years, 9 months ago (2015-03-06 17:52:05 UTC) #2
pdr.
LGTM @timloh, would you like to take a look too? https://codereview.chromium.org/983103003/diff/40001/Source/core/layout/style/SVGLayoutStyleDefs.h File Source/core/layout/style/SVGLayoutStyleDefs.h (right): https://codereview.chromium.org/983103003/diff/40001/Source/core/layout/style/SVGLayoutStyleDefs.h#newcode145 ...
5 years, 9 months ago (2015-03-06 18:47:08 UTC) #3
Timothy Loh
lgtm
5 years, 9 months ago (2015-03-08 23:29:25 UTC) #4
Eric Willigers
lgtm
5 years, 9 months ago (2015-03-09 08:07:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983103003/40001
5 years, 9 months ago (2015-03-09 09:48:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983103003/60001
5 years, 9 months ago (2015-03-09 13:02:01 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:19:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191544

Powered by Google App Engine
This is Rietveld 408576698