Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: Source/core/layout/style/SVGLayoutStyleTest.cpp

Issue 983103003: Use Length for the stroke-width property in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: lengthSetterForProperty Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/style/SVGLayoutStyleDefs.cpp ('k') | Source/core/layout/svg/LayoutSVGShape.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/style/SVGLayoutStyleTest.cpp
diff --git a/Source/core/layout/style/SVGLayoutStyleTest.cpp b/Source/core/layout/style/SVGLayoutStyleTest.cpp
index c4709a47a683f6278c0a51506ab57a9f0e73979c..7f0c90f5ca47c40ee497a1356917d89afd9d6397 100644
--- a/Source/core/layout/style/SVGLayoutStyleTest.cpp
+++ b/Source/core/layout/style/SVGLayoutStyleTest.cpp
@@ -5,26 +5,12 @@
#include "config.h"
#include "core/layout/style/SVGLayoutStyle.h"
-#include "core/svg/SVGLength.h"
-
#include <gtest/gtest.h>
using namespace blink;
namespace {
-// Ensures RefPtrWillBePersistent values are compared by their values, not by pointers.
-#define TEST_STYLE_REFPTRWILLBEPERSISTENT_VALUE_NO_DIFF(type, fieldName) \
- { \
- RefPtr<SVGLayoutStyle> svg1 = SVGLayoutStyle::create(); \
- RefPtr<SVGLayoutStyle> svg2 = SVGLayoutStyle::create(); \
- RefPtrWillBePersistent<type> value1 = type::create(); \
- RefPtrWillBePersistent<type> value2 = value1->clone(); \
- svg1->set##fieldName(value1); \
- svg2->set##fieldName(value2); \
- EXPECT_FALSE(svg1->diff(svg2.get()).hasDifference()); \
- }
-
// Ensures RefPtr values are compared by their values, not by pointers.
#define TEST_STYLE_REFPTR_VALUE_NO_DIFF(type, fieldName) \
{ \
@@ -53,7 +39,7 @@ TEST(SVGLayoutStyleTest, StrokeStyleShouldCompareValue)
{
TEST_STYLE_VALUE_NO_DIFF(float, StrokeOpacity);
TEST_STYLE_VALUE_NO_DIFF(float, StrokeMiterLimit);
- TEST_STYLE_REFPTRWILLBEPERSISTENT_VALUE_NO_DIFF(SVGLength, StrokeWidth);
+ TEST_STYLE_VALUE_NO_DIFF(UnzoomedLength, StrokeWidth);
TEST_STYLE_VALUE_NO_DIFF(Length, StrokeDashOffset);
TEST_STYLE_REFPTR_VALUE_NO_DIFF(SVGDashArray, StrokeDashArray);
« no previous file with comments | « Source/core/layout/style/SVGLayoutStyleDefs.cpp ('k') | Source/core/layout/svg/LayoutSVGShape.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698