Source/core/layout/style/SVGLayoutStyle.cpp - Issue 983103003: Use Length for the stroke-width property in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/style/SVGLayoutStyle.cpp

Issue 983103003: Use Length for the stroke-width property in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: lengthSetterForProperty Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/style/SVGLayoutStyle.cpp

diff --git a/Source/core/layout/style/SVGLayoutStyle.cpp b/Source/core/layout/style/SVGLayoutStyle.cpp

index 55957ff9cd4c6cb754709a64c0715080b48a343a..5d7759dc0ff41424ac8df3618d0d801c747e4850 100644

--- a/Source/core/layout/style/SVGLayoutStyle.cpp

+++ b/Source/core/layout/style/SVGLayoutStyle.cpp

@@ -175,7 +175,7 @@ bool SVGLayoutStyle::diffNeedsLayoutAndPaintInvalidation(const SVGLayoutStyle* o

// Some stroke properties, requires relayouts, as the cached stroke boundaries need to be recalculated.

if (stroke.get() != other->stroke.get()) {

- if (*stroke->width != *other->stroke->width

+ if (stroke->width != other->stroke->width

|| stroke->paintType != other->stroke->paintType

|| stroke->paintColor != other->stroke->paintColor

|| stroke->paintUri != other->stroke->paintUri