Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 982973003: Align base::Process::Terminate with base::KillProcess for Windows. (Closed)

Created:
5 years, 9 months ago by rvargas (doing something else)
Modified:
5 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align base::Process::Terminate with base::KillProcess for Windows. BUG=417532, 81449 Committed: https://crrev.com/639696bcf242b514f41bab37ba08f46291ff212d Cr-Commit-Position: refs/heads/master@{#319475}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M base/process/process_win.cc View 1 chunk +1 line, -10 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
rvargas (doing something else)
5 years, 9 months ago (2015-03-06 03:27:07 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/982973003/diff/1/base/process/process_win.cc File base/process/process_win.cc (left): https://codereview.chromium.org/982973003/diff/1/base/process/process_win.cc#oldcode131 base/process/process_win.cc:131: // software. http://crbug.com/81449. add this bug to the ...
5 years, 9 months ago (2015-03-06 13:14:41 UTC) #3
rvargas (doing something else)
Thanks https://codereview.chromium.org/982973003/diff/1/base/process/process_win.cc File base/process/process_win.cc (left): https://codereview.chromium.org/982973003/diff/1/base/process/process_win.cc#oldcode131 base/process/process_win.cc:131: // software. http://crbug.com/81449. On 2015/03/06 13:14:40, cpu wrote: ...
5 years, 9 months ago (2015-03-06 18:51:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982973003/1
5 years, 9 months ago (2015-03-06 18:53:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 19:15:18 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 19:16:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/639696bcf242b514f41bab37ba08f46291ff212d
Cr-Commit-Position: refs/heads/master@{#319475}

Powered by Google App Engine
This is Rietveld 408576698