Align base::Process::Terminate with base::KillProcess for Windows.

base/process/process_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/process.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/field_trial.h"
 #include "base/numerics/safe_conversions.h"
@@ skipping 106 matching lines @@
 
 void Process::Close() {
   is_current_process_ = false;
   if (!process_.IsValid())
     return;
 
   process_.Close();
 }
 
 void Process::Terminate(int result_code) {
-  DCHECK(IsValid());
-
-  // Call NtTerminateProcess directly, without going through the import table,
-  // which might have been hooked with a buggy replacement by third party
-  // software. http://crbug.com/81449.

[cpu_(ooo_6.6-7.5), 2015/03/06 13:14:40]

add this bug to the CL?

according to #35 there it was fixing something. That or some soviet-era paranoid
deal was going on.

[rvargas (doing something else), 2015/03/06 18:51:59]

Added to the description.

We should not be doing this anyway (to allow malware to go undetected), and
there's code somewhere else (KillProcess()) that doesn't have any detour when
calling TerminateProcess.

-  HMODULE module = GetModuleHandle(L"ntdll.dll");
-  typedef UINT (WINAPI *TerminateProcessPtr)(HANDLE handle, UINT code);
-  TerminateProcessPtr terminate_process = reinterpret_cast<TerminateProcessPtr>(
-      GetProcAddress(module, "NtTerminateProcess"));
-  terminate_process(Handle(), result_code);
+  ::TerminateProcess(Handle(), result_code);
 }
 
 bool Process::WaitForExit(int* exit_code) {
   return WaitForExitWithTimeout(TimeDelta::FromMilliseconds(INFINITE),
                                 exit_code);
 }
 
 bool Process::WaitForExitWithTimeout(TimeDelta timeout, int* exit_code) {
   // Limit timeout to INFINITE.
   DWORD timeout_ms = saturated_cast<DWORD>(timeout.InMilliseconds());
@@ skipping 46 matching lines @@
 
   return (::SetPriorityClass(Handle(), priority) != 0);
 }
 
 int Process::GetPriority() const {
   DCHECK(IsValid());
   return ::GetPriorityClass(Handle());
 }
 
 }  // namespace base