Align base::Process::Terminate with base::KillProcess for Windows.

base/process/process_win.cc

Index: base/process/process_win.cc
diff --git a/base/process/process_win.cc b/base/process/process_win.cc
index b62fdb4f8c38f55acb1696097813065dfe735a2c..fe4f9ec739eea656f1c1565a1e773988d0240c02 100644
--- a/base/process/process_win.cc
+++ b/base/process/process_win.cc
@@ -124,16 +124,7 @@ void Process::Close() {
 }
 
 void Process::Terminate(int result_code) {
-  DCHECK(IsValid());
-
-  // Call NtTerminateProcess directly, without going through the import table,
-  // which might have been hooked with a buggy replacement by third party
-  // software. http://crbug.com/81449.

[cpu_(ooo_6.6-7.5), 2015/03/06 13:14:40]

add this bug to the CL?

according to #35 there it was fixing something. That or some soviet-era paranoid
deal was going on.

[rvargas (doing something else), 2015/03/06 18:51:59]

Added to the description.

We should not be doing this anyway (to allow malware to go undetected), and
there's code somewhere else (KillProcess()) that doesn't have any detour when
calling TerminateProcess.

-  HMODULE module = GetModuleHandle(L"ntdll.dll");
-  typedef UINT (WINAPI *TerminateProcessPtr)(HANDLE handle, UINT code);
-  TerminateProcessPtr terminate_process = reinterpret_cast<TerminateProcessPtr>(
-      GetProcAddress(module, "NtTerminateProcess"));
-  terminate_process(Handle(), result_code);
+  ::TerminateProcess(Handle(), result_code);
 }
 
 bool Process::WaitForExit(int* exit_code) {