sync/internal_api/attachments/on_disk_attachment_store.cc - Issue 982883002: [Sync] Add size and crc32c to AttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/on_disk_attachment_store.cc

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix argument evaluation order bug. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/attachments/on_disk_attachment_store.cc

diff --git a/sync/internal_api/attachments/on_disk_attachment_store.cc b/sync/internal_api/attachments/on_disk_attachment_store.cc

index 7b715e03b7e7b254ecf6db283f285d218be9808f..f4c10e3b1af3451827c2a510725842d4387ea2e1 100644

--- a/sync/internal_api/attachments/on_disk_attachment_store.cc

+++ b/sync/internal_api/attachments/on_disk_attachment_store.cc

@@ -321,7 +321,7 @@ scoped_ptr<Attachment> OnDiskAttachmentStore::ReadSingleAttachment(

return attachment.Pass();

}

attachment.reset(

- new Attachment(Attachment::CreateFromParts(attachment_id, data, crc32c)));

+ new Attachment(Attachment::CreateFromParts(attachment_id, data)));

pavely 2015/03/07 00:07:25 Maybe check that attachment_id's crc matches the o

maniscalco 2015/03/09 17:09:00 Good idea. Done with test case to verify.

return attachment.Pass();

}