[Sync] Add size and crc32c to AttachmentId.

sync/internal_api/attachments/on_disk_attachment_store.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/public/attachments/on_disk_attachment_store.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/location.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 303 matching lines @@
     return attachment.Pass();
   }
   scoped_refptr<base::RefCountedMemory> data =
       base::RefCountedString::TakeString(&data_str);
   uint32_t crc32c = ComputeCrc32c(data);
   if (record_metadata.has_crc32c() && record_metadata.crc32c() != crc32c) {
     DVLOG(1) << "Attachment crc does not match";
     return attachment.Pass();
   }
   attachment.reset(
-      new Attachment(Attachment::CreateFromParts(attachment_id, data, crc32c)));
+      new Attachment(Attachment::CreateFromParts(attachment_id, data)));

[pavely, 2015/03/07 00:07:25]

Maybe check that attachment_id's crc matches the one from metadata record?
You can just leave TODO for me if you want. I'll be partying on this code next
week.

[maniscalco, 2015/03/09 17:09:00]

Good idea.  Done with test case to verify.

   return attachment.Pass();
 }
 
 bool OnDiskAttachmentStore::WriteSingleAttachment(
     const Attachment& attachment) {
   const std::string metadata_key =
       MakeMetadataKeyFromAttachmentId(attachment.GetId());
   const std::string data_key = MakeDataKeyFromAttachmentId(attachment.GetId());
 
   std::string metadata_str;
@@ skipping 62 matching lines @@
   return key;
 }
 
 AttachmentMetadata OnDiskAttachmentStore::MakeAttachmentMetadata(
     const AttachmentId& attachment_id,
     const attachment_store_pb::RecordMetadata& record_metadata) {
   return AttachmentMetadata(attachment_id, record_metadata.attachment_size());
 }
 
 }  // namespace syncer