sync/internal_api/attachments/fake_attachment_downloader_unittest.cc - Issue 982883002: [Sync] Add size and crc32c to AttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/fake_attachment_downloader_unittest.cc

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix argument evaluation order bug. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/internal_api/attachments/attachment_store_test_template.h ('K') | « sync/internal_api/attachments/fake_attachment_downloader.cc ('k') | sync/internal_api/attachments/on_disk_attachment_store.cc » ('j') | sync/internal_api/attachments/on_disk_attachment_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/fake_attachment_downloader_unittest.cc

diff --git a/sync/internal_api/attachments/fake_attachment_downloader_unittest.cc b/sync/internal_api/attachments/fake_attachment_downloader_unittest.cc

index 1436a497eb12bd83bd2908e17c352b9cf938e4b7..762da4498792cfa15ac9c584b21687e86155beb8 100644

--- a/sync/internal_api/attachments/fake_attachment_downloader_unittest.cc

+++ b/sync/internal_api/attachments/fake_attachment_downloader_unittest.cc

@@ -50,7 +50,7 @@ class FakeAttachmentDownloaderTest : public testing::Test {

};

TEST_F(FakeAttachmentDownloaderTest, DownloadAttachment) {

- AttachmentId attachment_id = AttachmentId::Create();

+ AttachmentId attachment_id = AttachmentId::Create(0, 0);

downloader()->DownloadAttachment(attachment_id, download_callback());

RunMessageLoop();

EXPECT_EQ(1U, download_results().size());